Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/tt-rss: small improvements #87261

Merged
merged 3 commits into from May 18, 2020
Merged

nixos/tt-rss: small improvements #87261

merged 3 commits into from May 18, 2020

Conversation

@symphorien
Copy link
Contributor

symphorien commented May 8, 2020

  • Fix logging by making it quiet by default and setting syslogIdentifier. Fixes #74427
  • Restart the daemon on failure
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
symphorien added 3 commits May 8, 2020
as should be the default with all long-running services
@symphorien
Copy link
Contributor Author

symphorien commented May 8, 2020

cc tt-rss maintainers @globin @zohl

@ajs124
ajs124 approved these changes May 9, 2020
@aanderse
Copy link
Contributor

aanderse commented May 18, 2020

I don't see anyone explicitly saying they have tested this. Since there isn't a NixOS test is anyone able to confirm this works with a real quick run through before we merge?

ping @symphorien @ajs124

@symphorien
Copy link
Contributor Author

symphorien commented May 18, 2020

Ah I forgot to tick the boxes but yes I tested it, notably the "restart on failure" part.

Copy link
Contributor

aanderse left a comment

Great! I guess we're good to merge then. Thanks 🎉

@aanderse aanderse merged commit f82e267 into NixOS:master May 18, 2020
15 checks passed
15 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8fc8eec"; rev="8fc8eec0e769a32bfd056106f42abe70c0af5dd8"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8fc8eec"; rev="8fc8eec0e769a32bfd056106f42abe70c0af5dd8"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8fc8eec"; rev="8fc8eec0e769a32bfd056106f42abe70c0af5dd8"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8fc8eec"; rev="8fc8eec0e769a32bfd056106f42abe70c0af5dd8"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8fc8eec"; rev="8fc8eec0e769a32bfd056106f42abe70c0af5dd8"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8fc8eec"; rev="8fc8eec0e769a32bfd056106f42abe70c0af5dd8"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8fc8eec"; rev="8fc8eec0e769a32bfd056106f42abe70c0af5dd8"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
tt-rss, tt-rss.passthru.tests on aarch64-linux Success
Details
tt-rss, tt-rss.passthru.tests on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.