Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

brave: 1.7.92 -> 1.8.95 #87277

Merged
merged 1 commit into from May 21, 2020
Merged

brave: 1.7.92 -> 1.8.95 #87277

merged 1 commit into from May 21, 2020

Conversation

@CheariX
Copy link
Contributor

CheariX commented May 8, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@ofborg ofborg bot requested review from rht and uskudnik May 8, 2020
@lourkeur lourkeur mentioned this pull request May 8, 2020
3 of 10 tasks complete
@dasJ
Copy link
Member

dasJ commented May 8, 2020

What happened to the PR title? :O

@CheariX CheariX changed the title <!-- To help with the large amounts of pull requests, we would appreciate your reviews of other pull requests, especially simple package updates. Just leave a comment describing what you have tested in the relevant package/service. Reviewing helps to reduce the average time-to-merge for everyone. Thanks a lot if you do! List of open PRs: https://github.com/NixOS/nixpkgs/pulls Reviewing guidelines: https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#chap-reviewing-contributions --> brave: 1.7.92 -> 1.8.90 May 8, 2020
@CheariX
Copy link
Contributor Author

CheariX commented May 8, 2020

What happened to the PR title? :O

Sorry. I used hub pull-request for the first time. Didn't even notice.

@rht
Copy link
Member

rht commented May 9, 2020

cc: @JeffLabonte for review.

Copy link
Contributor

JeffLabonte left a comment

LGTM

@CheariX CheariX changed the title brave: 1.7.92 -> 1.8.90 brave: 1.7.92 -> 1.8.95 May 15, 2020
@CheariX
Copy link
Contributor Author

CheariX commented May 15, 2020

Is there anything else we can to to help merging it?

@FelschR
Copy link
Contributor

FelschR commented May 20, 2020

Compiled and ran it with nix-review. Looks fine to me.

@nixos-discourse
Copy link

nixos-discourse commented May 20, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/158

@AndersonTorres AndersonTorres merged commit ca90190 into NixOS:master May 21, 2020
16 checks passed
16 checks passed
brave, brave.passthru.tests on aarch64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
brave, brave.passthru.tests on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="e659bf3"; rev="e659bf3ce4cab122c8d342d5c619dd82181a57f6"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="e659bf3"; rev="e659bf3ce4cab122c8d342d5c619dd82181a57f6"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="e659bf3"; rev="e659bf3ce4cab122c8d342d5c619dd82181a57f6"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="e659bf3"; rev="e659bf3ce4cab122c8d342d5c619dd82181a57f6"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="e659bf3"; rev="e659bf3ce4cab122c8d342d5c619dd82181a57f6"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="e659bf3"; rev="e659bf3ce4cab122c8d342d5c619dd82181a57f6"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="e659bf3"; rev="e659bf3ce4cab122c8d342d5c619dd82181a57f6"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
You can’t perform that action at this time.