Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perlPackages: make package set extensible #87299

Open
wants to merge 1 commit into
base: master
from

Conversation

@B4dM4n
Copy link
Contributor

B4dM4n commented May 8, 2020

Motivation for this change

Add the same overriding capabilities to the perlPackages set that pythonPackages and luaPackages already have.

Things done

It uses the same packageOverrides argument that pythonPackages and luaPackages also use and keeps the old config.perlPackageOverrides method.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@B4dM4n
Copy link
Contributor Author

B4dM4n commented May 8, 2020

@volth
Copy link
Contributor

volth commented May 9, 2020

Yes, there is TODO: for so long time.
I have not touch it only because perlPackageOverrides is used in many 3rd party overlays, dotfiles (GitHub search will show some of them).
But it should be done.

@volth
Copy link
Contributor

volth commented May 9, 2020

Interesting what is rebuild-linux: 1
OfBorg published the list on the Checks tab, but not this time :(

@volth volth requested review from rycee and teto May 9, 2020
@volth
Copy link
Contributor

volth commented May 9, 2020

@B4dM4n B4dM4n force-pushed the B4dM4n:perl-packages-extensible branch from 28ce62d to 2a53d26 May 9, 2020
@B4dM4n
Copy link
Contributor Author

B4dM4n commented May 9, 2020

The one rebuild was ikiwiki, which uses perlPackages.override to pass a modified pkgs set into perl-packages.nix.

I pushed a new version which passes along the pkgs from perl-modules/default.nix to perl-packages.nix to add that possibility again.

@volth
volth approved these changes Jun 3, 2020
@rycee
Copy link
Member

rycee commented Jun 3, 2020

Unfortunately I'm swamped with a bunch of other stuff, and also no longer work with Perl, so I cannot review this properly but I agree with the general idea of making the package set extensible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.