Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

giada: 0.16.1 -> 0.16.2.2 #87374

Merged
merged 1 commit into from May 9, 2020
Merged

giada: 0.16.1 -> 0.16.2.2 #87374

merged 1 commit into from May 9, 2020

Conversation

@prusnak
Copy link
Member

prusnak commented May 9, 2020

Motivation for this change

Version update + use system catch and nlohmann_json

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
+ use system catch and nlohmann_json
@prusnak prusnak requested a review from petabyteboy May 9, 2020
Copy link
Member

petabyteboy left a comment

LGTM 👍

@petabyteboy petabyteboy merged commit cfe68f2 into NixOS:master May 9, 2020
@prusnak prusnak deleted the prusnak:giada branch May 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.