Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update python manual to reference python 3.8 instead of 3.5 #87407

Merged
merged 1 commit into from May 9, 2020

Conversation

@bhipple
Copy link
Contributor

bhipple commented May 9, 2020

Improvement suggested in #87094

CC @FRidh @jonringer

Improvement suggested in #87094
@FRidh
FRidh approved these changes May 9, 2020
Copy link
Member

FRidh left a comment

Looks good. Will also need to get rid of blaze as example because that package is no longer maintained and entirely functioning.

@doronbehar
Copy link
Contributor

doronbehar commented May 9, 2020

Question: Why not use python3 so it will point to whatever's considered as Python3 ?

@FRidh
Copy link
Member

FRidh commented May 9, 2020

Depends on the exact use whether that is possible. Sometimes it's used to indicate specifically there are other versions available.

@prusnak
prusnak approved these changes May 9, 2020
@bhipple
Copy link
Contributor Author

bhipple commented May 9, 2020

Looks good. Will also need to get rid of blaze as example because that package is no longer maintained and entirely functioning.

Sounds good; I see a couple other things that are not idiomatic and could use touchups, but I'll send those in a follow-up and keep this PR just on the 3.5 -> 3.8 rename for easy reviewability.

@bhipple bhipple merged commit d373d80 into NixOS:master May 9, 2020
13 checks passed
13 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c0f434f"; rev="c0f434fcc8c2c37719a622ada98158977665f4e8"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c0f434f"; rev="c0f434fcc8c2c37719a622ada98158977665f4e8"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c0f434f"; rev="c0f434fcc8c2c37719a622ada98158977665f4e8"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c0f434f"; rev="c0f434fcc8c2c37719a622ada98158977665f4e8"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c0f434f"; rev="c0f434fcc8c2c37719a622ada98158977665f4e8"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c0f434f"; rev="c0f434fcc8c2c37719a622ada98158977665f4e8"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c0f434f"; rev="c0f434fcc8c2c37719a622ada98158977665f4e8"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@bhipple bhipple deleted the bhipple:doc/py38 branch May 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.