Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bashcards v0.1.2 #87408

Merged
merged 2 commits into from May 20, 2020
Merged

bashcards v0.1.2 #87408

merged 2 commits into from May 20, 2020

Conversation

@rpearce
Copy link
Contributor

rpearce commented May 9, 2020

Motivation for this change

Adds a bash CLI tool I created to practice flash cards (https://github.com/rpearce/bashcards). This is my first new package submission, so please let me know what I can do better.

Things done

Tested using nix-env -i bashcards -f path/to/my/nixpkgs on macOS Catalina

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Member

prusnak left a comment

Two suggestions, otherwise nice!

pkgs/tools/misc/bashcards/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/bashcards/default.nix Outdated Show resolved Hide resolved
@rpearce rpearce changed the title Bashcards bashcards v0.1.1 May 9, 2020
@prusnak
prusnak approved these changes May 9, 2020
@rpearce
Copy link
Contributor Author

rpearce commented May 9, 2020

If you don't mind, I got one more patch version bump to include version information in the tool!

Edit: all done! Sorry for the noise.

@rpearce rpearce changed the title bashcards v0.1.1 bashcards v0.1.2 May 9, 2020
@Lassulus
Copy link
Contributor

Lassulus commented May 19, 2020

heyho, can you squash the last 3 commits please? and name it accordingly.
thanks!

rpearce added 2 commits May 3, 2020
Adds bashcards, a CLI tool to practice flashcards.
@rpearce rpearce force-pushed the rpearce:bashcards branch from f8963d9 to cc2e800 May 20, 2020
@rpearce
Copy link
Contributor Author

rpearce commented May 20, 2020

@Lassulus done!

@Lassulus Lassulus merged commit f26e514 into NixOS:master May 20, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
bashcards, bashcards.passthru.tests on aarch64-linux Success
Details
bashcards, bashcards.passthru.tests on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="cc2e800"; rev="cc2e800a722e53b34f464dce80ffff76e397cbfa"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="cc2e800"; rev="cc2e800a722e53b34f464dce80ffff76e397cbfa"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="cc2e800"; rev="cc2e800a722e53b34f464dce80ffff76e397cbfa"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="cc2e800"; rev="cc2e800a722e53b34f464dce80ffff76e397cbfa"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="cc2e800"; rev="cc2e800a722e53b34f464dce80ffff76e397cbfa"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="cc2e800"; rev="cc2e800a722e53b34f464dce80ffff76e397cbfa"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="cc2e800"; rev="cc2e800a722e53b34f464dce80ffff76e397cbfa"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@rpearce rpearce deleted the rpearce:bashcards branch May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.