Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

glusterfs: fix snapshots #87417

Merged
merged 2 commits into from May 9, 2020
Merged

Conversation

@ajs124
Copy link
Member

ajs124 commented May 9, 2020

Motivation for this change

Snapshots were not working.

There might be a more elegant way to fixing this than replacing strings in headers, but this works.

cc @nh2

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@7c6f434c
Copy link
Member

7c6f434c commented May 9, 2020

@ofborg test glusterfs

@7c6f434c 7c6f434c merged commit e15ab2c into NixOS:master May 9, 2020
17 of 18 checks passed
17 of 18 checks passed
tests.glusterfs on x86_64-linux
Details
Evaluation Performance Report Evaluator Performance Report
Details
glusterfs, glusterfs.passthru.tests on aarch64-linux Success
Details
glusterfs, glusterfs.passthru.tests on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="faa621c"; rev="faa621ce76b68a1496812ca0b1b6b6dd19982c52"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="faa621c"; rev="faa621ce76b68a1496812ca0b1b6b6dd19982c52"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="faa621c"; rev="faa621ce76b68a1496812ca0b1b6b6dd19982c52"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="faa621c"; rev="faa621ce76b68a1496812ca0b1b6b6dd19982c52"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="faa621c"; rev="faa621ce76b68a1496812ca0b1b6b6dd19982c52"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="faa621c"; rev="faa621ce76b68a1496812ca0b1b6b6dd19982c52"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="faa621c"; rev="faa621ce76b68a1496812ca0b1b6b6dd19982c52"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
tests.glusterfs on aarch64-linux Success
Details
@ajs124 ajs124 deleted the helsinki-systems:fix/glusterfs_snapshots branch May 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.