Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/confinement: add conflict for ProtectSystem service option #87420

Closed
wants to merge 1 commit into from

Conversation

@martinetd
Copy link
Contributor

martinetd commented May 9, 2020

Motivation for this change

Systemd ProtectSystem is incompatible with the chroot we make
for confinement. The options is redundant with what we do anyway
so warn if it had been set and advise to disable it.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
    ran nixos/tests/systemd-confinement.nix tests successfully.
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Systemd ProtectSystem is incompatible with the chroot we make
for confinement. The options is redundant with what we do anyway
so warn if it had been set and advise to disable it.
@aszlig
aszlig approved these changes May 10, 2020
aszlig added a commit that referenced this pull request May 10, 2020
Systemd ProtectSystem is incompatible with the chroot we make
for confinement. The options is redundant with what we do anyway
so warn if it had been set and advise to disable it.

Merges: #87420
@aszlig
Copy link
Member

aszlig commented May 10, 2020

Merged by 4c81174, thanks for the contribution :-)

@aszlig aszlig closed this May 10, 2020
@martinetd
Copy link
Contributor Author

martinetd commented May 10, 2020

Thanks for the feature! I've had a fun time migrating all my containers to confined services, saved a lot of ram/time on nixos-rebuild and I believe the result is even better...

dashmoho pushed a commit to dashmoho/nixpkgs that referenced this pull request May 11, 2020
Systemd ProtectSystem is incompatible with the chroot we make
for confinement. The options is redundant with what we do anyway
so warn if it had been set and advise to disable it.

Merges: NixOS#87420
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.