Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mlflow-server: support additional packages for other database backends #87428

Open
wants to merge 1 commit into
base: master
from

Conversation

@tbenst
Copy link
Contributor

tbenst commented May 9, 2020

Motivation for this change

add postgres backend, make easier for user to add their own preferred.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@@ -10,7 +10,8 @@ py.toPythonApplication
propagatedBuildInputs = old.propagatedBuildInputs ++ [
py.boto3
py.mysqlclient
];
py.psycopg2
] ++ additionalPackages;

This comment has been minimized.

Copy link
@bhipple

bhipple May 10, 2020

Contributor

This seems unnecessary, since you can just take the resulting python application and call it with overrideAttrs to add more propagatedBuildInputs without the extra hook, right?

This comment has been minimized.

Copy link
@tbenst

tbenst May 10, 2020

Author Contributor

I thought so too, but didn't work:

  mlflow-server = super.mlflow-server.overrideAttrs (old: rec {
    propagatedBuildInputs = old.propagatedBuildInputs ++ [
      super.python3.packages.psycopg2
    ];
  });

I also tried an overlay for mlflow, but didn't work either.

This comment has been minimized.

Copy link
@tbenst

tbenst May 10, 2020

Author Contributor

I think it’s a quirk of toPythonApplication, but maybe I made a bonehead mistake

This comment has been minimized.

Copy link
@jonringer

jonringer May 11, 2020

Contributor

you may have to do overridePythonAttrs, I'm honestly not sure what the difference is

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.