Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python: coverage: 4.5.4 -> 5.1 #87430

Merged
merged 1 commit into from Jun 4, 2020
Merged

python: coverage: 4.5.4 -> 5.1 #87430

merged 1 commit into from Jun 4, 2020

Conversation

@vojta001
Copy link
Contributor

vojta001 commented May 9, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Contributor

jonringer left a comment

since this change causes over 500 rebuilds, do you mind targeting the staging branch

git rebase --onto=origin/staging HEAD~1
git push .. ... --force

then change the base branch in the github PR from master -> staging

See https://nixos.org/nixpkgs/manual/#submitting-changes-staging-branch for more details on staging branch

@vojta001 vojta001 force-pushed the vojta001:python-coverage branch from 0ea684b to de6120d May 12, 2020
@vojta001 vojta001 requested review from LnL7, matthewbauer and Mic92 as code owners May 12, 2020
@vojta001 vojta001 changed the base branch from master to staging May 12, 2020
@vojta001
Copy link
Contributor Author

vojta001 commented May 12, 2020

Sorry, my fault. Rebased.

@vojta001
Copy link
Contributor Author

vojta001 commented May 12, 2020

Is there any way one can check the number of rebuilds in advance?

@jonringer
Copy link
Contributor

jonringer commented May 12, 2020

You can do a nixpkgs-review wip (assuming your changes aren't committed yet), and it will say how many packages will be rebuilt

@jonringer
Copy link
Contributor

jonringer commented May 12, 2020

@GrahamcOfBorg build python3Packages.requests
@GrahamcOfBorg build python38Packages.requests

@jonringer
Copy link
Contributor

jonringer commented May 12, 2020

looks like there's a major regression with cffi in staging right now

@FRidh
Copy link
Member

FRidh commented Jun 4, 2020

This update should be fine by now. If it turns out it breaks (too many) Python packages, we revert in staging-next.

@FRidh FRidh merged commit d2d0700 into NixOS:staging Jun 4, 2020
21 of 23 checks passed
21 of 23 checks passed
python38Packages.requests on x86_64-darwin
Details
python3Packages.requests on x86_64-darwin
Details
(unknown attributes) on x86_64-darwin No attempt
Details
python38Packages.requests on aarch64-linux Failure
Details
python38Packages.requests on x86_64-linux Failure
Details
python3Packages.requests on aarch64-linux Failure
Details
python3Packages.requests on x86_64-linux Failure
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="de6120d"; rev="de6120d11a18716f1cb802d076f0e08b19ca19e5"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="de6120d"; rev="de6120d11a18716f1cb802d076f0e08b19ca19e5"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="de6120d"; rev="de6120d11a18716f1cb802d076f0e08b19ca19e5"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="de6120d"; rev="de6120d11a18716f1cb802d076f0e08b19ca19e5"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="de6120d"; rev="de6120d11a18716f1cb802d076f0e08b19ca19e5"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="de6120d"; rev="de6120d11a18716f1cb802d076f0e08b19ca19e5"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="de6120d"; rev="de6120d11a18716f1cb802d076f0e08b19ca19e5"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
python, python.passthru.tests on aarch64-linux Success
Details
python, python.passthru.tests on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.