Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redis: 5.0.8 -> 6.0.1 #87472

Merged
merged 1 commit into from May 16, 2020
Merged

redis: 5.0.8 -> 6.0.1 #87472

merged 1 commit into from May 16, 2020

Conversation

@r-ryantm
Copy link
Contributor

r-ryantm commented May 10, 2020

Semi-automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/redis/versions.

meta.description for redis is: "An open source, advanced key-value store"

meta.homepage for redis is: "https://redis.io"

Updates performed
  • Version update
To inspect upstream changes
Impact
Checks done (click to expand)

Rebuild report (if merged into master) (click to expand)
35 total rebuild path(s)

9 package rebuild(s)

9 x86_64-linux rebuild(s)
9 i686-linux rebuild(s)
8 x86_64-darwin rebuild(s)
9 aarch64-linux rebuild(s)


First fifty rebuilds by attrpath
python27Packages.pyres
python27Packages.python-redis-lock
python27Packages.remotecv
python37Packages.pyres
python37Packages.python-redis-lock
python38Packages.pyres
python38Packages.python-redis-lock
redis
suricata
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/z7awhsw567zwkair46x6gvymvqsr8wrp-redis-6.0.1 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A redis https://github.com/r-ryantm/nixpkgs/archive/4a07eb225b275105204ab0adbf711b6ba425a3cb.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/z7awhsw567zwkair46x6gvymvqsr8wrp-redis-6.0.1
ls -la /nix/store/z7awhsw567zwkair46x6gvymvqsr8wrp-redis-6.0.1/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review 1

8 packages built:
- python27Packages.pyres
- python27Packages.python-redis-lock
- python37Packages.pyres
- python37Packages.python-redis-lock
- python38Packages.pyres
- python38Packages.python-redis-lock
- redis
- suricata

Maintainer pings

cc @berdario @globin for testing.

@ofborg ofborg bot requested a review from globin May 10, 2020
@FRidh FRidh modified the milestones: 20.03, 20.09 May 10, 2020
@prusnak
Copy link
Member

prusnak commented May 10, 2020

Citing from: https://raw.githubusercontent.com/antirez/redis/6.0/00-RELEASENOTES

Migrating from 5.0 to 6.0
=========================

Redis 6.0 is mostly a strict superset of 5.0, you should not have any problem
upgrading your application from 5.0 to 6.0. However this is a list of small
non-backward compatible changes introduced in the 6.0 release:

* The SPOP <count> command no longer returns null when the set key does not
  exist. Now it returns the empty set as it should and as happens when it is
  called with a 0 argument. This is technically a fix, however it changes the
  old behavior.
@ryantm
Copy link
Member

ryantm commented May 10, 2020

The redis test is failing for ofborg, maybe related:

machine # [    9.208286] redis-server[746]: WARNING supervised by systemd - you MUST set appropriate values for TimeoutStartSec and TimeoutStopSec in your service unit.
@ryantm
Copy link
Member

ryantm commented May 10, 2020

It looks like that warning is unrelated, because even after I add those timeouts it still shows that warning.

@ajs124 ajs124 mentioned this pull request May 15, 2020
0 of 10 tasks complete
@marsam marsam merged commit 8d3b239 into NixOS:master May 16, 2020
17 checks passed
17 checks passed
redis, redis.passthru.tests on aarch64-linux Failure
Details
redis, redis.passthru.tests on x86_64-linux Failure
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="4a07eb2"; rev="4a07eb225b275105204ab0adbf711b6ba425a3cb"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="4a07eb2"; rev="4a07eb225b275105204ab0adbf711b6ba425a3cb"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="4a07eb2"; rev="4a07eb225b275105204ab0adbf711b6ba425a3cb"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="4a07eb2"; rev="4a07eb225b275105204ab0adbf711b6ba425a3cb"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="4a07eb2"; rev="4a07eb225b275105204ab0adbf711b6ba425a3cb"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="4a07eb2"; rev="4a07eb225b275105204ab0adbf711b6ba425a3cb"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="4a07eb2"; rev="4a07eb225b275105204ab0adbf711b6ba425a3cb"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
redis, redis.passthru.tests on x86_64-darwin Success
Details
@r-ryantm r-ryantm deleted the r-ryantm:auto-update/redis branch May 16, 2020
@JJJollyjim JJJollyjim mentioned this pull request May 17, 2020
3 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.