Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnomeExtensions.volume-mixer: bring it back and fix it #87481

Open
wants to merge 1 commit into
base: master
from

Conversation

@bjornfor
Copy link
Contributor

bjornfor commented May 10, 2020

Motivation for this change

Seems like a useful extension.

This reverts commit ee5506c.

Further:

  • Add it to the gnomeExtensions attrset. (The reason for removing it in
    the first place was because it wasn't registered there.)
  • Move from .../volume-mixer.nix to .../volume-mixer/default.nix, to
    align with the other extensions.
  • Update to latest version.
  • Fix the installPhase.
  • Comment that there is a Makefile for this package, but it requires
    npm, so keep the buildPhase unchanged.
  • Add missing deps: pulseaudio and python3
  • Add a small patch to find pulseaudio.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
This reverts commit ee5506c.

Further:
* Add it to the gnomeExtensions attrset. (The reason for removing it in
  the first place was because it wasn't registered there.)
* Move from .../volume-mixer.nix to .../volume-mixer/default.nix, to
  align with the other extensions.
* Update to latest version.
* Fix the installPhase.
* Comment that there is a Makefile for this package, but it requires
  npm, so keep the buildPhase unchanged.
* Add missing deps: pulseaudio and python3
* Add a small patch to find pulseaudio.
meta = with stdenv.lib; {
description = "GNOME Shell Extension allowing separate configuration of PulseAudio devices";
license = licenses.gpl2;
maintainers = with maintainers; [ aneeshusa ];

This comment has been minimized.

Copy link
@aneeshusa

aneeshusa May 19, 2020

Contributor

I don't use this extension anymore so I wouldn't be a good reviewer/maintainer.

This comment has been minimized.

Copy link
@bjornfor

bjornfor May 21, 2020

Author Contributor

Me neither. Do you want to be removed fron the maintainers list?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.