Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bazarr #87495

Merged
merged 3 commits into from May 22, 2020
Merged

Bazarr #87495

merged 3 commits into from May 22, 2020

Conversation

@xwvvvvwx
Copy link
Contributor

xwvvvvwx commented May 10, 2020

Motivation for this change

Adds a package and nixos module for https://github.com/morpheus65535/bazarr.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@xwvvvvwx xwvvvvwx force-pushed the xwvvvvwx:bazarr branch from 885e88a to ce4e1ff May 21, 2020
xwvvvvwx added 2 commits May 10, 2020
@xwvvvvwx xwvvvvwx force-pushed the xwvvvvwx:bazarr branch from ce4e1ff to 710e8db May 21, 2020
@xwvvvvwx
Copy link
Contributor Author

xwvvvvwx commented May 21, 2020

@bjornfor thanks for the review!

I made the following changes:

  • rebased on master
  • addressed review comments
  • added passthru.tests
  • added checks to only create bazarr user / group if required
@xwvvvvwx
Copy link
Contributor Author

xwvvvvwx commented May 22, 2020

bumped to 0.8.4.4

@bjornfor bjornfor merged commit 74bf0fa into NixOS:master May 22, 2020
17 checks passed
17 checks passed
editorconfig editorconfig
Details
Evaluation Performance Report Evaluator Performance Report
Details
bazarr, bazarr.passthru.tests on aarch64-linux Success
Details
bazarr, bazarr.passthru.tests on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="47c0855"; rev="47c0855060db2f6113cea9589cced6d7def3e157"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="47c0855"; rev="47c0855060db2f6113cea9589cced6d7def3e157"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="47c0855"; rev="47c0855060db2f6113cea9589cced6d7def3e157"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="47c0855"; rev="47c0855060db2f6113cea9589cced6d7def3e157"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="47c0855"; rev="47c0855060db2f6113cea9589cced6d7def3e157"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="47c0855"; rev="47c0855060db2f6113cea9589cced6d7def3e157"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="47c0855"; rev="47c0855060db2f6113cea9589cced6d7def3e157"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@xwvvvvwx xwvvvvwx deleted the xwvvvvwx:bazarr branch May 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.