Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python.pkgs.scikitlearn: 0.21.3 -> 0.22.2.post1 #87527

Merged
merged 2 commits into from May 12, 2020

Conversation

@timokau
Copy link
Member

timokau commented May 10, 2020

Motivation for this change

Surprisingly to me, scikitlearn hasn't been updated since November. Since I couldn't find a reason for that, here's the update.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@timokau
Copy link
Member Author

timokau commented May 10, 2020

nix-review:

15 packages failed to build:
python37Packages.imbalanced-learn python37Packages.optuna python37Packages.persim python37Packages.pygbm python37Packages.qasm2image python37Packages.qiskit python37Packages.qiskit-aqua python37Packages.ripser python37Packages.scikit-tda python38Packages.imbalanced-learn python38Packages.persim python38Packages.pygbm python38Packages.qiskit-aqua python38Packages.ripser python38Packages.scikit-tda

53 packages built:
python37Packages.batchgenerators python37Packages.bayesian-optimization python37Packages.dask-glm python37Packages.dask-ml python37Packages.dask-xgboost python37Packages.dftfit python37Packages.graspy python37Packages.hdbscan python37Packages.hmmlearn python37Packages.ignite python37Packages.kmapper python37Packages.librosa python37Packages.lightgbm python37Packages.mlrose python37Packages.nilearn python37Packages.osmnx python37Packages.qiskit-ignis python37Packages.scikit-bio python37Packages.scikit-optimize python37Packages.scikitlearn python37Packages.sklearn-deap python37Packages.textacy python37Packages.umap-learn python37Packages.vowpalwabbit python37Packages.word2vec python37Packages.xgboost python38Packages.batchgenerators python38Packages.bayesian-optimization python38Packages.dask-glm python38Packages.dask-ml python38Packages.dask-xgboost python38Packages.dftfit python38Packages.graspy python38Packages.hdbscan python38Packages.hmmlearn python38Packages.ignite python38Packages.kmapper python38Packages.librosa python38Packages.lightgbm python38Packages.mlrose python38Packages.nilearn python38Packages.osmnx python38Packages.qiskit-ignis python38Packages.scikit-bio python38Packages.scikit-optimize python38Packages.scikitlearn python38Packages.sklearn-deap python38Packages.textacy python38Packages.umap-learn python38Packages.vowpalwabbit python38Packages.word2vec python38Packages.xgboost tebreak
@timokau
Copy link
Member Author

timokau commented May 10, 2020

All of the failures are broken on master already.

Copy link
Contributor

bhipple left a comment

Actual bump looks good. 👍

minor = versions.minor version;
dashVer = replaceChars ["."] ["-"] version;
in
"https://scikit-learn.org/stable/whats_new/v${major}.${minor}.html#version-${dashVer}";

This comment has been minimized.

Copy link
@bhipple

bhipple May 11, 2020

Contributor

This is great. I'm going to update the nixpkgs-update bot to drop a link to meta.description in the PR description if it exists, btw:

ryantm/nixpkgs-update#200

I spent a lot of time looking for release notes when reviewing PRs, so it'll be good to have it a little more streamlined!

@jonringer
Copy link
Contributor

jonringer commented May 11, 2020

@GrahamcOfBorg build python3Packages.scikitlearn
@GrahamcOfBorg build python38Packages.scikitlearn

@timokau timokau merged commit ebf030b into NixOS:master May 12, 2020
20 checks passed
20 checks passed
python38Packages.scikitlearn on x86_64-darwin Timed out, unknown build status
Details
python3Packages.scikitlearn on x86_64-darwin Timed out, unknown build status
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="cd45ab0"; rev="cd45ab076dcd3168644b67a88bd85584619aa187"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="cd45ab0"; rev="cd45ab076dcd3168644b67a88bd85584619aa187"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="cd45ab0"; rev="cd45ab076dcd3168644b67a88bd85584619aa187"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="cd45ab0"; rev="cd45ab076dcd3168644b67a88bd85584619aa187"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="cd45ab0"; rev="cd45ab076dcd3168644b67a88bd85584619aa187"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="cd45ab0"; rev="cd45ab076dcd3168644b67a88bd85584619aa187"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="cd45ab0"; rev="cd45ab076dcd3168644b67a88bd85584619aa187"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
python38Packages.scikitlearn on aarch64-linux Success
Details
python38Packages.scikitlearn on x86_64-linux Success
Details
python3Packages.scikitlearn on aarch64-linux Success
Details
python3Packages.scikitlearn on x86_64-linux Success
Details
@timokau timokau deleted the timokau:scikitlearn-0.22.2 branch May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.