Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

teamspeak_client: update to 3.5.3 #87530

Merged
merged 1 commit into from May 19, 2020
Merged

teamspeak_client: update to 3.5.3 #87530

merged 1 commit into from May 19, 2020

Conversation

@lukegb
Copy link
Contributor

lukegb commented May 10, 2020

Motivation for this change

TeamSpeak3 Client is out of date, and the new 3.5.3 includes some audio changes
that make it annoying (but not impossible) to use with old versions.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@lukegb lukegb force-pushed the lukegb:update/teamspeak branch from 707f308 to f302f79 May 10, 2020
@ofborg ofborg bot requested a review from nathanielbaxter May 10, 2020
@lukegb lukegb marked this pull request as draft May 10, 2020
@lukegb lukegb force-pushed the lukegb:update/teamspeak branch from f302f79 to bf799b2 May 11, 2020
@lukegb lukegb marked this pull request as ready for review May 11, 2020
@lukegb lukegb marked this pull request as draft May 11, 2020
This now requires Qt5WebSockets, so that's been added as a dependency now.
@lukegb lukegb force-pushed the lukegb:update/teamspeak branch from bf799b2 to 029d3b3 May 16, 2020
@lukegb lukegb marked this pull request as ready for review May 16, 2020
@lukegb lukegb changed the title teamspeak_client: update to 3.5.2 teamspeak_client: update to 3.5.3 May 16, 2020
@Lassulus Lassulus merged commit aeeb341 into NixOS:master May 19, 2020
16 checks passed
16 checks passed
teamspeak_client, teamspeak_client.passthru.tests on aarch64-linux No attempt
Details
teamspeak_client, teamspeak_client.passthru.tests on x86_64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="029d3b3"; rev="029d3b3fa4509bdb9a8d792542fcb97dfd5cfb3b"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="029d3b3"; rev="029d3b3fa4509bdb9a8d792542fcb97dfd5cfb3b"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="029d3b3"; rev="029d3b3fa4509bdb9a8d792542fcb97dfd5cfb3b"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="029d3b3"; rev="029d3b3fa4509bdb9a8d792542fcb97dfd5cfb3b"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="029d3b3"; rev="029d3b3fa4509bdb9a8d792542fcb97dfd5cfb3b"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="029d3b3"; rev="029d3b3fa4509bdb9a8d792542fcb97dfd5cfb3b"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="029d3b3"; rev="029d3b3fa4509bdb9a8d792542fcb97dfd5cfb3b"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@lukegb lukegb deleted the lukegb:update/teamspeak branch May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.