Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vtk: 7.1.1 -> 8.2.0 #87544

Merged
merged 1 commit into from May 26, 2020
Merged

vtk: 7.1.1 -> 8.2.0 #87544

merged 1 commit into from May 26, 2020

Conversation

@bcdarwin
Copy link
Member

bcdarwin commented May 10, 2020

  • also create vtk_7 as several packages don't build with 8.x:

    • itk5: vtkVersion.h header not found at compile time
    • ants: version in tree (2.2.0) is incompatible with 8.2
    • itk4: ants depends on both vtk and itk4, so use vtk_7
    • gdcm: vtk header issue
    • python3Packages.vtk: Python C API compilation error with Python 3.8
  • upgrade vtkWithQt4 -> vtkWithQt5

Motivation for this change

VTK 9 is out and some packages (e.g., Fury, not yet in Nixpkgs) now require 8 or higher.

Resolves #49531.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • [NA] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
4 package marked as broken and skipped:
linuxPackages_hardkernel_4_14.r8125 linuxPackages_hardkernel_4_14.r8168 qes smimesign

13 package built:
cq-editor freecad mirtk opencascade pcl python27Packages.pythonocc-core python37Packages.cadquery python37Packages.pythonocc-core python38Packages.pythonocc-core smesh vtk vtk7 vtkWithQt5
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@bcdarwin bcdarwin requested review from FRidh and jonringer as code owners May 10, 2020
@bcdarwin
Copy link
Member Author

bcdarwin commented May 10, 2020

pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
@bcdarwin bcdarwin force-pushed the bcdarwin:vtk-8 branch from 9a0d4a2 to 11d836c May 11, 2020
@bcdarwin bcdarwin requested a review from FRidh May 11, 2020
- also create vtk_7 as several packages don't build with 8.x:
  - itk5: vtkVersion.h header not found at compile time
  - ants: version in tree (2.2.0) is incompatible with 8.2
  - itk4: ants depends on both vtk and itk4, so use vtk_7
  - gdcm: vtk header issue
  - python3Packages.vtk: Python C API compilation error with Python 3.8

- upgrade vtkWithQt4 -> vtkWithQt5
@bcdarwin bcdarwin force-pushed the bcdarwin:vtk-8 branch from 11d836c to 5e716bf May 11, 2020
@bhipple
Copy link
Contributor

bhipple commented May 26, 2020

Result of nixpkgs-review pr 87544 1

13 packages built:
- cq-editor
- freecad
- mirtk
- opencascade
- pcl
- python27Packages.pythonocc-core
- python37Packages.cadquery
- python37Packages.pythonocc-core
- python38Packages.pythonocc-core
- smesh
- vtk
- vtkWithQt5
- vtk_7
@bhipple bhipple merged commit d3082a3 into NixOS:master May 26, 2020
18 checks passed
18 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5e716bf"; rev="5e716bf469f616c34db40aa81d9b9c95e7aa22e5"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5e716bf"; rev="5e716bf469f616c34db40aa81d9b9c95e7aa22e5"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5e716bf"; rev="5e716bf469f616c34db40aa81d9b9c95e7aa22e5"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5e716bf"; rev="5e716bf469f616c34db40aa81d9b9c95e7aa22e5"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5e716bf"; rev="5e716bf469f616c34db40aa81d9b9c95e7aa22e5"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5e716bf"; rev="5e716bf469f616c34db40aa81d9b9c95e7aa22e5"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5e716bf"; rev="5e716bf469f616c34db40aa81d9b9c95e7aa22e5"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
vtk on aarch64-linux Success
Details
vtk on x86_64-linux Success
Details
vtk, vtk.passthru.tests on aarch64-linux Success
Details
vtk, vtk.passthru.tests on x86_64-linux Success
Details
@bcdarwin bcdarwin deleted the bcdarwin:vtk-8 branch May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.