Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

poezio: add setuptools as propagatedBuildInput #87550

Closed
wants to merge 1 commit into from

Conversation

@FireyFly
Copy link
Contributor

FireyFly commented May 10, 2020

This unbreaks the otherwise-broken package (setuptools is needed for importing pkg_resources).

Presumably this change should also be backported to the 20.03 release--I could add a PR to that branch as well, but figure it's best to sort out a merge to master first.

Motivation for this change

Unbreaking broken package.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
This unbreaks the otherwise-broken package (setuptools is needed for
importing pkg_resources).
@lsix
Copy link
Member

lsix commented Jun 12, 2020

Hi.

Sorry I missed your PR earlier. I had the exact same fix integrated into master in 0fa981b.

I just backported it to 20.03 in b6cda51

Thanks for the MR.

@lsix lsix closed this Jun 12, 2020
@FireyFly FireyFly deleted the FireyFly:pkgs/poezio/fix branch Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.