Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python packages: pyensembl and its dependencies, gffutils, pyBigWig #87551

Closed
wants to merge 10 commits into from

Conversation

@moritzschaefer
Copy link

moritzschaefer commented May 10, 2020

Motivation for this change

Both pyenseml and gffutils are commonly used python packages (> 100 stars on GitHub), so I added them to nix packages.

Things done
  • Built on platform(s)
    • NixOS
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/) (only pyensembl has a supplemental binary)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • [-] Mostly Fits CONTRIBUTING.md. I designed the derivations 1:1 to existing ones.
Vizaxo and others added 5 commits May 27, 2019
Add config option services.xserver.windowManager.exwm.loadScript,
which is passed to Emacs (as the -l option) to load after the user's init file.
nixos/exwm: allow custom Emacs load script
@FRidh
Copy link
Member

FRidh commented May 14, 2020

Please rebase, don't merge master.

@adisbladis adisbladis removed their request for review May 14, 2020
Copy link
Member

FRidh left a comment

Please ensure the modules are somehow tested. Maybe supporting the unit tests is too much, but we have the pythonImportsCheckHook so you could do import checks at least.

Also, remove empty lists and strings.

Finally, will you maintain the new packages?


pybedtools = callPackage ../development/python-modules/pybedtools { };

pyBigWig = callPackage ../development/python-modules/pyBigWig { };

This comment has been minimized.

Copy link
@FRidh

FRidh May 30, 2020

Member

normalized names (lowercase and dashes instead of underscores)

@moritzschaefer moritzschaefer changed the title Add python packages: pyensembl (and its dependencies) + gffutils Add python packages: pyensembl and its dependencies, gffutils, pyBigWig May 30, 2020
@moritzschaefer
Copy link
Author

moritzschaefer commented May 30, 2020

@FRidh thanks for pointing this out. The module 'pybigwig' already existed in the correct format (lowercase) so I just reverted that commit.

I cannot guarantee to maintain the packages in a timely manner, but will try to update their versions from time to time.

I'm rebasing to master now and will push then.

New rebase is here: #89213
I close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.