Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yoshimi: 1.7.0.1 -> 1.7.1 #87572

Closed
wants to merge 1 commit into from
Closed

Conversation

@r-ryantm
Copy link
Contributor

r-ryantm commented May 11, 2020

Semi-automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/yoshimi/versions.

meta.description for yoshimi is: "High quality software synthesizer based on ZynAddSubFX"

meta.homepage for yoshimi is: "http://yoshimi.sourceforge.net"

Updates performed
  • Version update
To inspect upstream changes
Impact
Checks done (click to expand)

Rebuild report (if merged into master) (click to expand)
3 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
0 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)


First fifty rebuilds by attrpath
yoshimi
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/3bpi0x16iiamx0s5y84gklm0r58ix5v8-yoshimi-1.7.1 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A yoshimi https://github.com/r-ryantm/nixpkgs/archive/dceacf0575a94f2251cbbc364b1a37c53c3619c9.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/3bpi0x16iiamx0s5y84gklm0r58ix5v8-yoshimi-1.7.1
ls -la /nix/store/3bpi0x16iiamx0s5y84gklm0r58ix5v8-yoshimi-1.7.1/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review 1

1 package built:
- yoshimi

Maintainer pings

cc @cillianderoiste for testing.

Copy link
Contributor

jonringer left a comment

no longer builds on master:

/build/yoshimi-1.7.1/src/LV2_Plugin/YoshimiLV2Plugin.cpp:833:25: error: invalid conversion from 'void* (*)(const _LV2UI_Descriptor*, const char*, const char*, LV2UI_Write_Function, LV2UI_Controller, void**, const LV2_Feature* const*)' {aka 'void* (*)(const _LV2UI_Descriptor*, const char*, const char*, void (*)(void*, unsigned int, unsigned int, unsigned int, const void*), void*, void**, const LV2_Feature* const*)'} to 'void* (*)(const LV2UI_Descriptor*, const char*, const char*, LV2UI_Write_Function, LV2UI_Controller, void**, const LV2_Feature* const*)' {aka 'void* (*)(const LV2UI_Descriptor*, const char*, const char*, void (*)(void*, unsigned int, unsigned int, unsigned int, const void*), void*, void**, const LV2_Feature* const*)'} [-fpermissive]
  833 |     YoshimiLV2PluginUI::instantiate,
      |     ~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~
      |                         |
      |                         void* (*)(const _LV2UI_Descriptor*, const char*, const char*, LV2UI_Write_Function, LV2UI_Controller, void**, const LV2_Feature* const*) {aka void* (*)(const _LV2UI_Descriptor*, const char*, const char*, void (*)(void*, unsigned int, unsigned int, unsigned int, const void*), void*, void**, const LV2_Feature* const*)}
@jonringer jonringer closed this May 13, 2020
@minijackson
Copy link
Contributor

minijackson commented May 15, 2020

Note that a very similar error is present in yoshimi-1.7.0.1:

/build/yoshimi-1.7.0.1/src/LV2_Plugin/YoshimiLV2Plugin.cpp:80:23: error: invalid conversion from 'void* (*)(const _LV2_Descriptor*, double, const char*, const LV2_Feature* const*)' to 'void* (*)(const LV2_Descriptor*, double, const char*, const LV2_Feature* const*)' [-fpermissive]
   80 |     YoshimiLV2Plugin::instantiate,
      |     ~~~~~~~~~~~~~~~~~~^~~~~~~~~~~
      |                       |
      |                       void* (*)(const _LV2_Descriptor*, double, const char*, const LV2_Feature* const*)

I just got this error today from the nixpkgs-unstable channel, but I don't know what changed in master that could have caused this.

@minijackson
Copy link
Contributor

minijackson commented May 15, 2020

It seems that infamousPlugins has the same error and it might be from the minor bump of lv2 that breaks API: #86985

Exemple fix: openAVproductions/openAV-ArtyFX@6010d1a

@r-ryantm r-ryantm deleted the r-ryantm:auto-update/yoshimi branch May 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.