Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webkitgtk: reenable Hydra build #87580

Merged
merged 1 commit into from May 12, 2020
Merged

webkitgtk: reenable Hydra build #87580

merged 1 commit into from May 12, 2020

Conversation

@lopsided98
Copy link
Contributor

lopsided98 commented May 11, 2020

Motivation for this change

AFAICT, hydraPlatforms = [] serves no purpose for webkitgtk except making it more difficult to see if the build is succeeding on Hydra. The package is still built and hold up channels because many other packages depend on it.

See 8726c6d for the commit that originally added this line.

cc @NixOS/gnome

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@vcunat
vcunat approved these changes May 11, 2020
Copy link
Member

vcunat left a comment

Borg shows the "newly built" paths: https://gist.github.com/GrahamcOfBorg/e07d085d4e7c4bde56d06d1d43e9f231

It's just a single derivation per platform (checked locally), and surely used as dependency in others that get built.

vcunat referenced this pull request May 11, 2020
This package takes an excessive amount of time to build (e.g., right
now Hydra is showing eight concurrent builds of webkitgtk, some of
them running for more than 6 hours). This may also delay channel
updates.
@worldofpeace worldofpeace merged commit 1e3ff03 into NixOS:master May 12, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7d4c60f"; rev="7d4c60f76acc520a780d9f055a288b29805eda0c"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7d4c60f"; rev="7d4c60f76acc520a780d9f055a288b29805eda0c"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7d4c60f"; rev="7d4c60f76acc520a780d9f055a288b29805eda0c"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7d4c60f"; rev="7d4c60f76acc520a780d9f055a288b29805eda0c"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7d4c60f"; rev="7d4c60f76acc520a780d9f055a288b29805eda0c"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7d4c60f"; rev="7d4c60f76acc520a780d9f055a288b29805eda0c"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7d4c60f"; rev="7d4c60f76acc520a780d9f055a288b29805eda0c"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
webkitgtk, webkitgtk.passthru.tests on aarch64-linux Success
Details
webkitgtk, webkitgtk.passthru.tests on x86_64-linux Success
Details
@lopsided98 lopsided98 deleted the lopsided98:patch-2 branch May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.