Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lite: init at 1.03 #87589

Closed
wants to merge 1 commit into from
Closed

lite: init at 1.03 #87589

wants to merge 1 commit into from

Conversation

@filalex77
Copy link
Contributor

filalex77 commented May 11, 2020

Motivation for this change

https://github.com/rxi/lite/releases/tag/v1.03

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@utdemir
Copy link
Member

utdemir commented May 11, 2020

I got an error running it on NixOS:

❯ git rev-parse --short HEAD
65e441dc63c
❯ $(nix-build -A lite --builders "")/bin/lite
Error: [string "local core..."]:7: module 'core' not found:
	no field package.preload['core']
	no file '/nix/store/2w58n6psn9ax6qiyin18ix9xljdnlg11-lite-1.03/bin/data/core/init.lua'
	no file '/nix/store/2w58n6psn9ax6qiyin18ix9xljdnlg11-lite-1.03/bin/data/core.lua'
	no file '/usr/local/share/lua/5.2/core.lua'
	no file '/usr/local/share/lua/5.2/core/init.lua'
	no file '/usr/local/lib/lua/5.2/core.lua'
	no file '/usr/local/lib/lua/5.2/core/init.lua'
	no file './core.lua'
	no file '/usr/local/lib/lua/5.2/core.so'
	no file '/usr/local/lib/lua/5.2/loadall.so'
	no file './core.so'
stack traceback:
	[C]: in function 'require'
	[string "local core..."]:7: in function <[string "local core..."]:2>
	[C]: in function 'xpcall'
	[string "local core..."]:2: in main chunk
@HugoReeves
Copy link
Contributor

HugoReeves commented May 11, 2020

Possibly a duplicate of #87434
As it was the first PR and seems to have slightly more feedback, you may want to ask the author of #87434 to add you as one of the maintainers on their PR.

@prusnak
Copy link
Member

prusnak commented May 11, 2020

The bug above is fixed in my PR #87434

@filalex77 I'll add you as a maintainer in my PR and we can close this PR, agreed?

@filalex77
Copy link
Contributor Author

filalex77 commented May 11, 2020

@prusnak Yeah, sure!

@prusnak
Copy link
Member

prusnak commented May 11, 2020

OK, added.

Closing. Superseded by #87434

@prusnak prusnak closed this May 11, 2020
@prusnak prusnak mentioned this pull request May 11, 2020
3 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.