Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jgmenu: optionally install a xfce4 panel plugin #87597

Merged
merged 3 commits into from May 14, 2020
Merged

Conversation

@romildo
Copy link
Contributor

romildo commented May 11, 2020

Motivation for this change
  • jgmenu: format with nixpkgs-fmt

  • jgmenu: no need to explicitly set prefix make flag

    • It is automatically passed to the configure script.
  • jgmenu: optionally install a xfce4 panel plugin

    • It is a contrib feature.
    • Default to false.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
romildo added 3 commits May 11, 2020
It is automatically passed to the configure script.
- It is a contrib feature.
- Default to false.
@romildo romildo merged commit effd217 into NixOS:master May 14, 2020
17 checks passed
17 checks passed
jgmenu, jgmenu.passthru.tests on x86_64-darwin No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="be7b83b"; rev="be7b83b460a6b90367885340121c2edf2a016389"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="be7b83b"; rev="be7b83b460a6b90367885340121c2edf2a016389"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="be7b83b"; rev="be7b83b460a6b90367885340121c2edf2a016389"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="be7b83b"; rev="be7b83b460a6b90367885340121c2edf2a016389"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="be7b83b"; rev="be7b83b460a6b90367885340121c2edf2a016389"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="be7b83b"; rev="be7b83b460a6b90367885340121c2edf2a016389"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="be7b83b"; rev="be7b83b460a6b90367885340121c2edf2a016389"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
jgmenu, jgmenu.passthru.tests on aarch64-linux Success
Details
jgmenu, jgmenu.passthru.tests on x86_64-linux Success
Details
@romildo romildo deleted the romildo:upd.jgmenu branch May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.