Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.pelican: Add patch from upstream for failing tests with… #87600

Open
wants to merge 1 commit into
base: master
from

Conversation

@dashmoho
Copy link

dashmoho commented May 11, 2020

… updated pygments version

Motivation for this change

This fixes issue with failing tests (#83513).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
… updated pygments version
@Moredread
Copy link
Contributor

Moredread commented May 11, 2020

A slight improvement would be to get the patch via fetchpatch like in

But already a big thanks for tracking this down. ;)

@dashmoho
Copy link
Author

dashmoho commented May 11, 2020

Patch also contains fixes for some other files, e.g. in custom_locale, which we are removing from tarball. But I'll use it for future, thanks!

Copy link
Contributor

Moredread left a comment

Commit message has a spelling mistake 'pythonPackaes.pelican' instead of 'pythonPackages.pelican'. Besides that everything looks good. :) Tested with nix-review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.