Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyp: init at 0.2.1 #87605

Open
wants to merge 1 commit into
base: master
from
Open

pyp: init at 0.2.1 #87605

wants to merge 1 commit into from

Conversation

@Kha
Copy link
Contributor

Kha commented May 11, 2020

As featured on Hacker News: run Python one-liners with ease

I took the sources from Github instead of pypi because the latter doesn't include tests, if that makes sense.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@@ -0,0 +1,29 @@
{ lib, fetchFromGitHub, python3Packages, pkgs }:

This comment has been minimized.

@FRidh

FRidh May 11, 2020 Member

No pkgs but explicit parameters such as jq and bc.

This comment has been minimized.

@Kha

Kha May 11, 2020 Author Contributor

Done, thanks. I felt a bit silly adding dependencies just because of two tests, but as long as they're not in the actual closure that's okay I suppose.

@Kha Kha force-pushed the Kha:pyp branch from 8c59ff5 to a97a5f3 May 11, 2020
@bachp
bachp approved these changes May 25, 2020
Copy link
Member

bachp left a comment

It's working a expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.