Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

matrix-nio: update #87610

Merged
merged 3 commits into from Jun 16, 2020
Merged

matrix-nio: update #87610

merged 3 commits into from Jun 16, 2020

Conversation

@symphorien
Copy link
Contributor

symphorien commented May 11, 2020

Support for decrypting images in pantalaimon

Briefly tested pantalaimon.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@emilazy
Copy link
Member

emilazy commented May 12, 2020

Result of nixpkgs-review pr 87610 1

3 packages built:
- pantalaimon
- python37Packages.matrix-nio
- weechatScripts.weechat-matrix
Copy link
Member

emilazy left a comment

weechat-matrix seems to work fine for me.

@emilazy emilazy mentioned this pull request May 12, 2020
5 of 10 tasks complete
@symphorien
Copy link
Contributor Author

symphorien commented May 21, 2020

Updated matrix-nio to 0.12.0.
Changelog https://github.com/poljar/matrix-nio/blob/master/CHANGELOG.md
Checked with pantalaimon that I could do interactive verification.

@symphorien symphorien requested a review from emilazy May 21, 2020
Copy link
Member

emilazy left a comment

Been running this for a few days with weechat-matrix, seems fine to me.

@symphorien symphorien force-pushed the symphorien:pan2 branch from ca0ee42 to 98ebd83 Jun 4, 2020
@symphorien
Copy link
Contributor Author

symphorien commented Jun 4, 2020

Apparently pantalaimon was independently udpated elsewhere, remains only the matrix-nio update.

@symphorien symphorien changed the title pantalaimon, matrix-nio: update matrix-nio: update Jun 4, 2020
@ofborg ofborg bot requested a review from emilazy Jun 4, 2020
@Ekleog
Copy link
Member

Ekleog commented Jun 16, 2020

Thank you! :D

@Ekleog Ekleog merged commit 0b2bd1f into NixOS:master Jun 16, 2020
14 checks passed
14 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="98ebd83"; rev="98ebd83d4658c64e38cafbb99b80f97ecf910df1"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="98ebd83"; rev="98ebd83d4658c64e38cafbb99b80f97ecf910df1"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="98ebd83"; rev="98ebd83d4658c64e38cafbb99b80f97ecf910df1"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="98ebd83"; rev="98ebd83d4658c64e38cafbb99b80f97ecf910df1"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="98ebd83"; rev="98ebd83d4658c64e38cafbb99b80f97ecf910df1"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="98ebd83"; rev="98ebd83d4658c64e38cafbb99b80f97ecf910df1"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="98ebd83"; rev="98ebd83d4658c64e38cafbb99b80f97ecf910df1"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.