Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
[20.03] nixos/test-driver: Specify /bin/sh shell when running a bourne shell script as the user #87618
Motivation for this change
Backport #87414 , which allows tests to run when a user has changed their login shell.
(cherry picked from commit 751a270)
Reason: Back-porting this straight-forward fix is the best way to
…script as the user (cherry picked from commit 751a270) Reason: Back-porting this straight-forward fix is the best way to allow tests affected by this user-shell problem to run in 20.03. There isn't a great override point to apply just this fix. Copy/pasting testing-python.nix just to specify a new test-driver.py isn't great -- it would cut off receiving any other fixes in the testing infrastructure until 20.09. A 20.03 system using testing-python.nix from the unstable branch and then passing 20.03's pkgs in to avoid getting unstable's pkgs is quite a bit of configuration to expect from clients and seems fragile against future changes in the unstable branch that expect pkgs to be mostly in-sync with the test driver. Both of these not-great options leave a bunch of "TODO: Remove after 20.09" junk in clients' configs & make that upgrade harder.