Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ipget: 0.3.2 -> 0.6.0 #87619

Merged
merged 1 commit into from May 24, 2020
Merged

ipget: 0.3.2 -> 0.6.0 #87619

merged 1 commit into from May 24, 2020

Conversation

@Luflosi
Copy link
Contributor

Luflosi commented May 11, 2020

Motivation for this change

https://github.com/ipfs/ipget/releases/tag/v0.6.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Is this the correct way to specify the goDeps? I couldn't get it to compile with fetchgx, so I just converted the go.sum file in the ipget project to a deps.nix file and added it in the directory.

@Luflosi
Copy link
Contributor Author

Luflosi commented May 12, 2020

I think I found a better solution by using buildGoModule instead of buildGoPackage. I also added myself as a maintainer for this package.

@ofborg ofborg bot requested a review from kalbasit May 12, 2020
@Luflosi Luflosi force-pushed the Luflosi:update/ipget branch from 0074ed3 to 8e3c58d May 23, 2020
@Luflosi Luflosi changed the title ipget: 0.3.2 -> 0.5.0 ipget: 0.3.2 -> 0.6.0 May 23, 2020
@Luflosi
Copy link
Contributor Author

Luflosi commented May 23, 2020

I updated the PR from 0.5.0 to 0.6.0 as a new version was released. Can somebody please review? Maybe @Mic92? I'm not sure who I should ping.

@Mic92 Mic92 merged commit bcb05f0 into NixOS:master May 24, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8e3c58d"; rev="8e3c58d1d8ce83552bdc6cc372184c7256e463fb"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8e3c58d"; rev="8e3c58d1d8ce83552bdc6cc372184c7256e463fb"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8e3c58d"; rev="8e3c58d1d8ce83552bdc6cc372184c7256e463fb"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8e3c58d"; rev="8e3c58d1d8ce83552bdc6cc372184c7256e463fb"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8e3c58d"; rev="8e3c58d1d8ce83552bdc6cc372184c7256e463fb"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8e3c58d"; rev="8e3c58d1d8ce83552bdc6cc372184c7256e463fb"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8e3c58d"; rev="8e3c58d1d8ce83552bdc6cc372184c7256e463fb"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
ipget, ipget.passthru.tests on aarch64-linux Success
Details
ipget, ipget.passthru.tests on x86_64-linux Success
Details
@Luflosi Luflosi deleted the Luflosi:update/ipget branch May 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.