Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] python.pkgs.mycroft-precise: init at 2020-02-14 #87621

Open
wants to merge 7 commits into
base: master
from

Conversation

@timokau
Copy link
Member

timokau commented May 11, 2020

Motivation for this change

I wanted to experiment with hotword-triggered voice memos. Unfortunately this turned out to be more complicated than I had hoped.

For now python3.pkgs.mycroft-precise builds and runs. It doesn't work as expected though. Maybe MycroftAI/mycroft-precise#141 will help. I don't know when or if I'll continue to work on this, so I thought I'd put it out there in its current state.

If you'd like to take this over, please do. I maintain enough packages already and I'm not sure if I'll finish this and commit to maintaining it.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@timokau timokau requested review from FRidh and jonringer as code owners May 11, 2020
@timokau timokau mentioned this pull request May 11, 2020
3 of 8 tasks complete
@timokau
Copy link
Member Author

timokau commented May 11, 2020

If you want to play with this, clone the community data repository at https://github.com/MycroftAI/precise-community-data and use one of the models. For example if you've cloned the repo to ~/repos/Precise-Community-Data and unpacked the computer model under computer/model, you can use precise-engine to detect the hotword in their sample data:

result/bin/precise-engine ~/repos/Precise-Community-Data/computer/models/computer-en-0.2.0-20190814-eltocino/computer-en.pb < ~/repos/Precise-Community-Data/computer/en/computer-en-117c2f25-4ab5-4620-84c4-84cf1bb7af49.wav

you should see an activation above 0.5 for their samples (currently that is not the case). Alternatively you can try it with your microphone's input:

result/bin/precise-listen -b ~/repos/Precise-Community-Data/computer/models/computer-en-0.2.0-20190814-eltocino/computer-en.pb

a ! should pop up when you say the word "computer" (it currently doesn't though).

@timokau
Copy link
Member Author

timokau commented Jun 16, 2020

/marvin opt-in
/status needs_work

@marvin-mk2
Copy link

marvin-mk2 bot commented Jun 16, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. The stages are

  • needs_review, if the author considers this PR ready
  • needs_work if the PR in its current form is not ready yet. Maybe the reviewer requested changes, there is an ongoing discussion or you are waiting for upstream feedback.
  • needs_merge can be set by reviewers who do not have merge permission but would merge this PR if they could.

Anybody can switch the current status with a comment of the form /status <new_status_here>.

Feedback and contributions to this bot are appreciated.

@timokau
Copy link
Member Author

timokau commented Jul 6, 2020

/status awaiting_changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.