Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cortextool: init at version 0.1.4 #87627

Open
wants to merge 1 commit into
base: master
from
Open

Conversation

@ekpdt
Copy link
Contributor

ekpdt commented May 11, 2020

Motivation for this change

Add cortextool, a CLI for interacting with Cortex instances.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@ekpdt ekpdt force-pushed the ekpdt:cortextool-init branch from 457d3e2 to 4872a56 May 11, 2020
@kalbasit
Copy link
Member

kalbasit commented May 12, 2020

aarch64 is failing. Please restrict this package to linux/darwin. doc 👉 https://nixos.org/nixpkgs/manual/#chap-meta

@ekpdt
Copy link
Contributor Author

ekpdt commented May 12, 2020

Is it possible this is a generalized problem with the go packaging rather than a platform specific issue? Both aarch64-linux and x86_64-linux fail with a complaint about the +incompatible suffix introduced in go 1.13
k8s.io/client-go@v12.0.0+incompatible: invalid version: +incompatible suffix not allowed: module contains a go.mod file, so semantic import versioning is required

@ekpdt
Copy link
Contributor Author

ekpdt commented May 13, 2020

I was able to build this package by applying this PR to nixpkgs back when it used go 1.12 (not 1.13 or 1.14). So it looks like the go.mod in the upstream sources is incompatible with more recent versions of go.

@ekpdt
Copy link
Contributor Author

ekpdt commented May 13, 2020

The upstream project uses -mod=vendor in conjunction with go build, not go mod. See https://github.com/grafana/cortextool/blob/master/Makefile
It's a bit beyond me at the moment to figure out how (or even if) to shim this into the buildGoModule machinery.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.