Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3.pkgs.ipykernel: skip test_unc_paths on darwin #87628

Merged
merged 2 commits into from May 11, 2020

Conversation

@badmutex
Copy link
Contributor

badmutex commented May 11, 2020

Motivation for this change

Fix #87626

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@badmutex badmutex requested review from FRidh and jonringer as code owners May 11, 2020
Co-authored-by: Dmitry Kalinkin <dmitry.kalinkin@gmail.com>
@veprbl
Copy link
Member

veprbl commented May 11, 2020

@GrahamcOfBorg build python37Packages.ipykernel python38Packages.ipykernel

@jonringer jonringer merged commit 7914726 into NixOS:master May 11, 2020
1 of 3 checks passed
1 of 3 checks passed
python37Packages.ipykernel, python38Packages.ipykernel on x86_64-darwin
Details
python37Packages.ipykernel, python38Packages.ipykernel on x86_64-linux
Details
python37Packages.ipykernel, python38Packages.ipykernel on aarch64-linux Success
Details
@jonringer
Copy link
Contributor

jonringer commented May 11, 2020

squashed and merged

@badmutex badmutex deleted the badmutex:patch-1 branch May 12, 2020
dashmoho pushed a commit to dashmoho/nixpkgs that referenced this pull request May 14, 2020
* Skip `test_unc_paths` on darwin

* point to upstream issue

Co-authored-by: Dmitry Kalinkin <dmitry.kalinkin@gmail.com>

Co-authored-by: Dmitry Kalinkin <dmitry.kalinkin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.