Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.qiskit: 0.18.2 -> 0.19.1 #87631

Merged
merged 7 commits into from May 12, 2020

Conversation

@drewrisinger
Copy link
Contributor

drewrisinger commented May 11, 2020

Motivation for this change

Bumps metapackage and subcomponents according to https://qiskit.org/documentation/release_notes.html

Also fixes python3Packages.qiskit-aqua breakage on master. Tried to bisect to figure out what caused the breakage but couldn't diagnose. Closest I got was maybe pythonPackages.ipykernel??

Closes #87432.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@drewrisinger drewrisinger marked this pull request as ready for review May 11, 2020
@drewrisinger drewrisinger requested review from FRidh and jonringer as code owners May 11, 2020
@ofborg ofborg bot added the 6.topic: python label May 12, 2020
@ofborg ofborg bot requested a review from pandaman64 May 12, 2020
@bhipple
Copy link
Contributor

bhipple commented May 12, 2020

Result of nixpkgs-review pr 87631 1

1 package marked as broken and skipped:
- python38Packages.qiskit-ibmq-provider
11 packages built:
- python37Packages.qasm2image
- python37Packages.qiskit
- python37Packages.qiskit-aer
- python37Packages.qiskit-aqua
- python37Packages.qiskit-ibmq-provider
- python37Packages.qiskit-ignis
- python37Packages.qiskit-terra
- python38Packages.qiskit-aer
- python38Packages.qiskit-aqua
- python38Packages.qiskit-ignis
- python38Packages.qiskit-terra
@drewrisinger
Copy link
Contributor Author

drewrisinger commented May 12, 2020

Will also update dependency pythonPackages.pylatexenc, just released a new version.

EDIT: python38Packages.qiskit-ibmq-provider is broken b/c upstream python38Packages.aiohttp is disabled on python38. Not sure why it's reported this way.

@drewrisinger drewrisinger force-pushed the drewrisinger:dr-pr-qiskit-bump branch from 9ae886f to 09a4374 May 12, 2020
Copy link
Contributor

jonringer left a comment

LGTM

https://github.com/NixOS/nixpkgs/pull/87631
14 packages built:
python27Packages.pylatexenc python37Packages.pylatexenc python37Packages.qasm2image python37Packages.qiskit python37Packages.qiskit-aer python37Packages.qiskit-aqua python37Packages.qiskit-ibmq-provider python37Packages.qiskit-ignis python37Packages.qiskit-terra python38Packages.pylatexenc python38Packages.qiskit-aer python38Packages.qiskit-aqua python38Packages.qiskit-ignis python38Packages.qiskit-terra
@jonringer jonringer merged commit 25f5b20 into NixOS:master May 12, 2020
14 checks passed
14 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="09a4374"; rev="09a437401095a54391a60415b0d954752f4706d1"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="09a4374"; rev="09a437401095a54391a60415b0d954752f4706d1"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="09a4374"; rev="09a437401095a54391a60415b0d954752f4706d1"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="09a4374"; rev="09a437401095a54391a60415b0d954752f4706d1"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="09a4374"; rev="09a437401095a54391a60415b0d954752f4706d1"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="09a4374"; rev="09a437401095a54391a60415b0d954752f4706d1"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="09a4374"; rev="09a437401095a54391a60415b0d954752f4706d1"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@drewrisinger drewrisinger deleted the drewrisinger:dr-pr-qiskit-bump branch May 12, 2020
@drewrisinger
Copy link
Contributor Author

drewrisinger commented May 12, 2020

Thanks @jonringer for the quick merge.

@jonringer
Copy link
Contributor

jonringer commented May 12, 2020

I was busy with personal stuff, you just happened to catch me at a good time! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.