Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

matrix-appservice-slack: 1.2.0 -> 1.3.1 #87665

Merged
merged 2 commits into from Jun 3, 2020

Conversation

@kampka
Copy link
Contributor

kampka commented May 12, 2020

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@kampka
Copy link
Contributor Author

kampka commented May 12, 2020

@GrahamcOfBorg build matrix-appservice-slack

kampka added 2 commits May 12, 2020
@kampka kampka force-pushed the kampka:matrix-appservice-slack branch from 28cfcd4 to e384c70 May 13, 2020
@kampka kampka changed the title matrix-appservice-slack: 1.2.0 -> 1.3.0 matrix-appservice-slack: 1.2.0 -> 1.3.1 May 13, 2020
@kampka
Copy link
Contributor Author

kampka commented May 13, 2020

@GrahamcOfBorg build matrix-appservice-slack

Copy link
Member

mmilata left a comment

Changes look good and the package builds and runs fine! Haven't done any testing of functionality yet.

mmilata added a commit to otevrenamesta/otevrenamesta-cz-configuration that referenced this pull request May 20, 2020
mmilata added a commit to otevrenamesta/otevrenamesta-cz-configuration that referenced this pull request May 20, 2020
@mmilata
Copy link
Member

mmilata commented May 21, 2020

Confirming that this version works 👍

Off-topic: have you seen this error before?

Error: ENOENT: no such file or directory, open 'config/slack-config-schema.yaml'
fs.js:114
    throw err;
    ^
Error: ENOENT: no such file or directory, open 'config/slack-config-schema.yaml'
    at Object.openSync (fs.js:443:3)
    at Object.readFileSync (fs.js:343:35)
    at ConfigValidator._loadFromFile (/nix/store/kv4w6rqv49jimq961wq3l7mx10cwzbr9-node_matrix-appservice-slack-1.3.1/lib/node_modules/matrix-appservice-slack/node_modules/matrix-appservice-bridge/lib/components/config-validator.js:63:29)
    at new ConfigValidator (/nix/store/kv4w6rqv49jimq961wq3l7mx10cwzbr9-node_matrix-appservice-slack-1.3.1/lib/node_modules/matrix-appservice-slack/node_modules/matrix-appservice-bridge/lib/components/config-validator.js:29:28)
    at Cli._loadConfig (/nix/store/kv4w6rqv49jimq961wq3l7mx10cwzbr9-node_matrix-appservice-slack-1.3.1/lib/node_modules/matrix-appservice-slack/node_modules/matrix-appservice-bridge/lib/components/cli.js:159:21)
    at Cli._assignConfigFile (/nix/store/kv4w6rqv49jimq961wq3l7mx10cwzbr9-node_matrix-appservice-slack-1.3.1/lib/node_modules/matrix-appservice-slack/node_modules/matrix-appservice-bridge/lib/components/cli.js:144:23)
    at Cli.run (/nix/store/kv4w6rqv49jimq961wq3l7mx10cwzbr9-node_matrix-appservice-slack-1.3.1/lib/node_modules/matrix-appservice-slack/node_modules/matrix-appservice-bridge/lib/components/cli.js:139:10)
    at Object.<anonymous> (/nix/store/kv4w6rqv49jimq961wq3l7mx10cwzbr9-node_matrix-appservice-slack-1.3.1/lib/node_modules/matrix-appservice-slack/lib/app.js:57:5)
    at Module._compile (internal/modules/cjs/loader.js:778:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:789:10)
    at Module.load (internal/modules/cjs/loader.js:653:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:593:12)
    at Function.Module._load (internal/modules/cjs/loader.js:585:3)
    at Function.Module.runMain (internal/modules/cjs/loader.js:831:12)
    at startup (internal/bootstrap/node.js:283:19)
    at bootstrapNodeJSCore (internal/bootstrap/node.js:623:3)

Do you have to change the current working directory to ${pkg}/lib/node_modules/matrix-appservice-slack before running matrix-appservice-slack or am I missing something?

@kampka
Copy link
Contributor Author

kampka commented May 22, 2020

Do you have to change the current working directory to ${pkg}/lib/node_modules/matrix-appservice-slack before running matrix-appservice-slack or am I missing something?

Yes, pretty much. I have a service configuration for it that looks like this:
https://gist.github.com/kampka/a3d05fde767aabea612a040129ffa259

@mmilata
Copy link
Member

mmilata commented May 22, 2020

That's very similar to service what I ended up with:) If matrix-org/matrix-appservice-slack#415 is merged it won't be needed in next release.

@WilliButz WilliButz merged commit 86a8c3f into NixOS:master Jun 3, 2020
18 checks passed
18 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="e384c70"; rev="e384c70ddaebbfec72ed588c005de0cc4b30901f"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="e384c70"; rev="e384c70ddaebbfec72ed588c005de0cc4b30901f"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="e384c70"; rev="e384c70ddaebbfec72ed588c005de0cc4b30901f"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="e384c70"; rev="e384c70ddaebbfec72ed588c005de0cc4b30901f"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="e384c70"; rev="e384c70ddaebbfec72ed588c005de0cc4b30901f"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="e384c70"; rev="e384c70ddaebbfec72ed588c005de0cc4b30901f"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="e384c70"; rev="e384c70ddaebbfec72ed588c005de0cc4b30901f"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
matrix-appservice-slack on aarch64-linux Success
Details
matrix-appservice-slack on x86_64-linux Success
Details
matrix-appservice-slack, matrix-appservice-slack.passthru.tests on aarch64-linux Success
Details
matrix-appservice-slack, matrix-appservice-slack.passthru.tests on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.