Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unrpa: init at 2.3.0 #87677

Merged
merged 2 commits into from May 13, 2020
Merged

unrpa: init at 2.3.0 #87677

merged 2 commits into from May 13, 2020

Conversation

@leo60228
Copy link
Contributor

leo60228 commented May 12, 2020

Motivation for this change

I wanted to use it.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • N/A: Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • N/A: Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • N/A: Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Contributor

jonringer left a comment

There are no tests included. Please try to checkout from source and check if they have unit tests, and try to run them. Unit tests give a good indication that they package has a high degree of validity and correctness given the python package set.

If tests are not available, then please use pythonImportsCheck to import the most important modules. This isn't as good as unit tests, but will usually give a good indication of run-time errors.


----------------------------------------------------------------------
Ran 0 tests in 0.000s
pkgs/development/python-modules/unrpa/default.nix Outdated Show resolved Hide resolved
Copy link
Contributor

jonringer left a comment

Also, commit message should be the install-path: message, so:

pythonPackages.unrpa: init at 2.3.0
@leo60228
Copy link
Contributor Author

leo60228 commented May 12, 2020

Also, commit message should be the install-path: message, so:

Is this documented anywhere? CONTRIBUTING.md says it should be pkg-name.

@leo60228 leo60228 force-pushed the leo60228:unrpa branch from d10c117 to 4fbc726 May 12, 2020
@jonringer
Copy link
Contributor

jonringer commented May 12, 2020

Is this documented anywhere? CONTRIBUTING.md says it should be pkg-name.

If it was a top-level attribute, these two things are the same. However, this exists on the python package set, which is slightly different.

I agree that the wording isn't super explicit about what this means

@jonringer
Copy link
Contributor

jonringer commented May 12, 2020

Reading about the package, it seems that we are more interested in the executable, rather than being able to import it as a library. So we should be using buildPythonApplication, please read https://github.com/NixOS/nixpkgs/blob/master/doc/languages-frameworks/python.section.md#buildpythonapplication-function for more details on packaging python applications with nix :)

@leo60228
Copy link
Contributor Author

leo60228 commented May 12, 2020

As using it as a library is a supported usecase, should toPythonApplication not be used instead? This is similar to youtube-dl (where usage as an application is much more common), which is the example for toPythonApplication.

@jonringer
Copy link
Contributor

jonringer commented May 13, 2020

yea, that seems good

Copy link
Contributor

jonringer left a comment

LGTM

Result of nixpkgs-review pr 87677 1

2 packages built: - unrpa (python37Packages.unrpa) - python38Packages.unrpa

@jonringer jonringer merged commit 53c48c2 into NixOS:master May 13, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9d92f61"; rev="9d92f615312eca89f925ff67b48575db1e294f53"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9d92f61"; rev="9d92f615312eca89f925ff67b48575db1e294f53"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9d92f61"; rev="9d92f615312eca89f925ff67b48575db1e294f53"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9d92f61"; rev="9d92f615312eca89f925ff67b48575db1e294f53"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9d92f61"; rev="9d92f615312eca89f925ff67b48575db1e294f53"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9d92f61"; rev="9d92f615312eca89f925ff67b48575db1e294f53"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9d92f61"; rev="9d92f615312eca89f925ff67b48575db1e294f53"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
unrpa, unrpa.passthru.tests on aarch64-linux Success
Details
unrpa, unrpa.passthru.tests on x86_64-linux Success
Details
leo60228 added a commit to leo60228/unrpa that referenced this pull request May 13, 2020
I've added a NixOS package in NixOS/nixpkgs#87677. After some looking, the only other distro I could find with a package was Gentoo.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.