Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/manual: document use of systemd to mount filesystems #87684

Merged
merged 2 commits into from May 14, 2020

Conversation

@glasserc
Copy link
Contributor

glasserc commented May 12, 2020

Motivation for this change

Fixes #87291.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

/cc @flokli

@glasserc glasserc changed the title nixos/manual: Document use of systemd to mount filesystems nixos/manual: document use of systemd to mount filesystems May 12, 2020
Copy link
Contributor

flokli left a comment

Thanks for following up! Suggested something explaining what does what here, PTAL.

nixos/doc/manual/configuration/file-systems.xml Outdated Show resolved Hide resolved
@flokli flokli merged commit b59b741 into NixOS:master May 14, 2020
14 checks passed
14 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b683d09"; rev="b683d09256ca1900818615f4c1ec847fdbd5fbca"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b683d09"; rev="b683d09256ca1900818615f4c1ec847fdbd5fbca"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b683d09"; rev="b683d09256ca1900818615f4c1ec847fdbd5fbca"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b683d09"; rev="b683d09256ca1900818615f4c1ec847fdbd5fbca"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b683d09"; rev="b683d09256ca1900818615f4c1ec847fdbd5fbca"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b683d09"; rev="b683d09256ca1900818615f4c1ec847fdbd5fbca"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b683d09"; rev="b683d09256ca1900818615f4c1ec847fdbd5fbca"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
dashmoho pushed a commit to dashmoho/nixpkgs that referenced this pull request May 14, 2020
* nixos/manual: document use of systemd to mount filesystems
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.