Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libgnurl: reduce size of closure. Remove unnecessary/old dependencies, #87685

Open
wants to merge 1 commit into
base: master
from

Conversation

@teknokatze
Copy link

teknokatze commented May 12, 2020

use python3, remove groff, remove nghttp2.

Motivation for this change

Reduction of closure size for gnurl and dependent packages

Things done

I haven't tested this, but I am the maintainer of the software and I have packaged it for various package managers, actively maintain the pkgsrc port of it.
Note: you might want to test moving the perl dependency to the tests phase (as far as I am aware only running tests requires perl, and if it's not detected some things are skipped), and you might want to add py-impacket to the tests phase as it has been removed in-tree.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
use python3, remove groff, remove nghttp2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.