Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

glpaper: init at unstable-2020-03-30 #87689

Closed
wants to merge 1 commit into from
Closed

Conversation

@ccellado
Copy link
Contributor

ccellado commented May 12, 2020

Motivation for this change

Add new useful package to the Wayland stack.

Things done

Added glpaper package.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
pkgs/development/tools/glpaper/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/glpaper/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/glpaper/default.nix Outdated Show resolved Hide resolved
@ccellado ccellado changed the title glpaper -> add glpaper: init at a95db77088df May 12, 2020
@ccellado ccellado force-pushed the ccellado:glpaper branch 4 times, most recently from 7ab37a5 to 5527cb3 May 12, 2020
@ccellado ccellado force-pushed the ccellado:glpaper branch 2 times, most recently from 22cbf67 to a469552 May 12, 2020
@ccellado
Copy link
Contributor Author

ccellado commented May 12, 2020

Added myself to maintainers list.

@ccellado ccellado force-pushed the ccellado:glpaper branch from cf887bd to 7fcf3bc May 12, 2020
@ccellado ccellado requested a review from jtojnar May 14, 2020
@ccellado
Copy link
Contributor Author

ccellado commented May 16, 2020

@jtojnar Anything else?

pkgs/development/tools/glpaper/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/glpaper/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/glpaper/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/glpaper/default.nix Outdated Show resolved Hide resolved
@ccellado ccellado force-pushed the ccellado:glpaper branch from a670f3d to c6d67e6 May 16, 2020
	modified:   maintainers/maintainer-list.nix
	new file:   pkgs/development/tools/glpaper/default.nix
	modified:   pkgs/top-level/all-packages.nix
@ccellado ccellado force-pushed the ccellado:glpaper branch from 6fa8ba3 to 4d00d0a May 16, 2020
@ccellado ccellado requested a review from adisbladis as a code owner May 16, 2020
@ofborg ofborg bot added the 6.topic: emacs label May 16, 2020
Copy link
Contributor Author

ccellado left a comment

Messed up my commits when squashed them, how to remove there ones?

@ccellado ccellado changed the title glpaper: init at a95db77088df glpaper: init at unstable-2020-03-30 May 16, 2020
@ccellado
Copy link
Contributor Author

ccellado commented May 16, 2020

Got mixed up branches, recreated cleanly at #87953

Sorry for the inconvenience.

@ccellado ccellado closed this May 16, 2020
@ccellado ccellado deleted the ccellado:glpaper branch May 16, 2020
@jtojnar
Copy link
Contributor

jtojnar commented May 16, 2020

In the future, you can use git reset --hard commit to change branch to point to a different commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.