Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kexectools: always pass host and target to configure #87690

Merged
merged 1 commit into from May 12, 2020

Conversation

@Gaelan
Copy link
Contributor

Gaelan commented May 12, 2020

Motivation for this change

Fixes #56290.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@Gaelan
Copy link
Contributor Author

Gaelan commented May 12, 2020

Gulp, didn't realize how much depended on this. Lemme rebase to staging

@Gaelan Gaelan force-pushed the Gaelan:kexec-tools-cross branch from 7342fe6 to b6beb43 May 12, 2020
@Gaelan Gaelan changed the base branch from master to staging May 12, 2020
@Gaelan
Copy link
Contributor Author

Gaelan commented May 12, 2020

Alright, on staging now. Sorry for the spurious review requests!

@Mic92
Copy link
Contributor

Mic92 commented May 12, 2020

@GrahamcOfBorg build kexectools

@Mic92 Mic92 merged commit b9a81f7 into NixOS:staging May 12, 2020
19 checks passed
19 checks passed
kexectools on x86_64-darwin No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b6beb43"; rev="b6beb43dd7c20e34d3d9e2078b0fa2945009c9b9"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b6beb43"; rev="b6beb43dd7c20e34d3d9e2078b0fa2945009c9b9"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b6beb43"; rev="b6beb43dd7c20e34d3d9e2078b0fa2945009c9b9"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b6beb43"; rev="b6beb43dd7c20e34d3d9e2078b0fa2945009c9b9"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b6beb43"; rev="b6beb43dd7c20e34d3d9e2078b0fa2945009c9b9"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b6beb43"; rev="b6beb43dd7c20e34d3d9e2078b0fa2945009c9b9"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b6beb43"; rev="b6beb43dd7c20e34d3d9e2078b0fa2945009c9b9"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
kexectools on aarch64-linux Success
Details
kexectools on x86_64-linux Success
Details
kexectools, kexectools.passthru.tests on aarch64-linux Success
Details
kexectools, kexectools.passthru.tests on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.