Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prometheus: Split options listenAddress and port #87700

Open
wants to merge 1 commit into
base: master
from

Conversation

@mkaito
Copy link
Contributor

mkaito commented May 12, 2020

Motivation for this change

Accessing the configured port of a service is quite useful, for example when configuring virtual hosts for a service. The prometheus module did not expose the configured por separately, making it unnecessarily cumbersome to consume.

Things done

The option listenAddress currently has the format host:port. I've split this into two options listenAddress for the host, and port for the port, and updated the defaults.

This is a breaking change only if you were setting listenAddress to a non-standard value. If you were, you should now set listenAddress and port separately.

Perhaps there should be an assertion that listenAddress does not end in :[0-9]+$ or similar, but I'm honestly not sure how to implement that.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Accessing the configured port of a service is quite useful, for example
when configuring virtual hosts for a service. The prometheus module did
not expose the configured por separately, making it unnecessarily
cumbersome to consume.

This is a breaking change only if you were setting `listenAddress` to
a non-standard value. If you were, you should now set `listenAddress`
and `port` separately.
@mkaito mkaito force-pushed the serokell:mkaito/upstream/prometheus-port branch from 5f658a8 to ba3c3de May 19, 2020
@Lassulus
Copy link
Contributor

Lassulus commented Jun 2, 2020

maybe this could be a good check?
builtins.match ".*:.*" "127.0.0.1:1234" == null

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.