Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qutebrowser: 1.10.0 -> 1.11.1 #87701

Merged
merged 3 commits into from May 13, 2020
Merged

Conversation

@dotlambda
Copy link
Member

dotlambda commented May 12, 2020

Motivation for this change

fixes CVE-2020-11054
"backport" of #87671

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @bjornfor

(cherry picked from commit 1619ec9)
@bjornfor
Copy link
Contributor

bjornfor commented May 13, 2020

Does this mean moving from 1.10 to 1.11 on the stable branch is too much? (If it's acceptible, it seems like the simpler way: just cherry-pick straight from master.)

@rnhmjoj
Copy link
Contributor

rnhmjoj commented May 13, 2020

I'd say to simply cherry-pick the update to 1.11. From the changelog there are only a few minor incompatibilities but much more fixes.

paumr and others added 2 commits May 1, 2020
(cherry picked from commit 4a5b853)
fixes CVE-2020-11054

(cherry picked from commit 52fcfd3)
@dotlambda dotlambda force-pushed the dotlambda:qutebrowser-1.10.2 branch from 5320549 to 19d8982 May 13, 2020
@dotlambda dotlambda changed the title qutebrowser: 1.10.0 -> 1.10.2 qutebrowser: 1.10.0 -> 1.11.1 May 13, 2020
@bjornfor bjornfor merged commit c3e2cbf into NixOS:release-20.03 May 13, 2020
17 checks passed
17 checks passed
qutebrowser, qutebrowser.passthru.tests on x86_64-darwin Failure
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="19d8982"; rev="19d898219dcf2c2ffefe42cef3355333f08bdc36"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="19d8982"; rev="19d898219dcf2c2ffefe42cef3355333f08bdc36"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="19d8982"; rev="19d898219dcf2c2ffefe42cef3355333f08bdc36"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="19d8982"; rev="19d898219dcf2c2ffefe42cef3355333f08bdc36"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="19d8982"; rev="19d898219dcf2c2ffefe42cef3355333f08bdc36"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="19d8982"; rev="19d898219dcf2c2ffefe42cef3355333f08bdc36"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="19d8982"; rev="19d898219dcf2c2ffefe42cef3355333f08bdc36"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
qutebrowser, qutebrowser.passthru.tests on aarch64-linux Success
Details
qutebrowser, qutebrowser.passthru.tests on x86_64-linux Success
Details
@dotlambda dotlambda deleted the dotlambda:qutebrowser-1.10.2 branch May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.