Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkgsi686Linux.cmake: compile with _FILE_OFFSET_BITS=64 for 32-bit targets #87704

Merged
merged 1 commit into from May 19, 2020

Conversation

@veprbl
Copy link
Member

veprbl commented May 12, 2020

Motivation for this change

This fixes a heisenbug https://gitlab.kitware.com/cmake/cmake/-/issues/20568

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @volth as pkgsi686Linux user (IIRC)

@volth
Copy link
Contributor

volth commented May 12, 2020

LGTM.
There are more 32-bit targets to test: pkgsCross.armv7l-hf-multiplatform, etc

@veprbl
Copy link
Member Author

veprbl commented May 12, 2020

pkgsCross.armv7l-hf-multiplatform.cmake bootstraps just fine with this, but, I guess, I can't test it further without setting up qemu-user.

@ttuegel ttuegel merged commit 694d80b into NixOS:master May 19, 2020
17 checks passed
17 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
cmake, cmake.passthru.tests on aarch64-linux Success
Details
cmake, cmake.passthru.tests on x86_64-darwin Success
Details
cmake, cmake.passthru.tests on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="467a87b"; rev="467a87ba1de5b0fc3f714d052552f28dcc27bc85"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="467a87b"; rev="467a87ba1de5b0fc3f714d052552f28dcc27bc85"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="467a87b"; rev="467a87ba1de5b0fc3f714d052552f28dcc27bc85"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="467a87b"; rev="467a87ba1de5b0fc3f714d052552f28dcc27bc85"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="467a87b"; rev="467a87ba1de5b0fc3f714d052552f28dcc27bc85"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="467a87b"; rev="467a87ba1de5b0fc3f714d052552f28dcc27bc85"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="467a87b"; rev="467a87ba1de5b0fc3f714d052552f28dcc27bc85"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.