Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap pkg-config #87705

Merged
merged 3 commits into from May 16, 2020
Merged

Wrap pkg-config #87705

merged 3 commits into from May 16, 2020

Conversation

@Ericson2314
Copy link
Member

Ericson2314 commented May 12, 2020

Motivation for this change

Fix #86077

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@Ericson2314 Ericson2314 requested a review from matthewbauer May 12, 2020
@Ericson2314 Ericson2314 requested review from FRidh and jonringer as code owners May 12, 2020
@Ericson2314 Ericson2314 changed the title Wrap pkg config Wrap pkg-config May 12, 2020
@ofborg ofborg bot added the 6.topic: python label May 12, 2020
@Ericson2314 Ericson2314 force-pushed the Ericson2314:wrap-pkg-config branch 6 times, most recently from 99fb295 to 7581c8a May 13, 2020
@Ericson2314 Ericson2314 force-pushed the Ericson2314:wrap-pkg-config branch from 7581c8a to ee8cfe4 May 16, 2020
@Ericson2314
Copy link
Member Author

Ericson2314 commented May 16, 2020

The LLVM test's dep's failure is unrelated, and the gcc one past locally.

@Ericson2314 Ericson2314 merged commit 75c55c4 into NixOS:staging May 16, 2020
2 of 4 checks passed
2 of 4 checks passed
grahamcofborg-eval Complete, with errors
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@Ericson2314 Ericson2314 deleted the Ericson2314:wrap-pkg-config branch May 16, 2020
@mmilata mmilata mentioned this pull request May 18, 2020
3 of 10 tasks complete
@FRidh
Copy link
Member

FRidh commented May 29, 2020

Discussion regarding failure on staging #89170

FRidh added a commit that referenced this pull request May 29, 2020
@samueldr samueldr mentioned this pull request Jun 5, 2020
0 of 10 tasks complete
@FRidh
Copy link
Member

FRidh commented Jun 6, 2020

Cross-compilation failure is now blocking staging-next #89388 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.