Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ssm-session-manager-plugin: rename #87707

Closed
wants to merge 0 commits into from
Closed

Conversation

@martinbaillie
Copy link
Contributor

martinbaillie commented May 13, 2020

Motivation for this change

Rename recently added ssm-session-manager-plugin to aws-session-manager-plugin to match AUR. Also add @socksy as maintainer.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@martinbaillie martinbaillie requested a review from ryantm May 13, 2020
@martinbaillie martinbaillie mentioned this pull request May 13, 2020
3 of 10 tasks complete
@ryantm
Copy link
Member

ryantm commented May 13, 2020

I think you should also rename the attrpath in all packages.

@martinbaillie
Copy link
Contributor Author

martinbaillie commented May 13, 2020

Just for full background I kept the attr the same so that it sat next to its big brother (attr: ssm-agent, pname: amazon-ssm-agent). Still think it makes sense to change @ryantm?

Copy link
Member

emilazy left a comment

The attribute name is still ssm-session-manager-plugin; you might want to adjust pkgs/top-level/all-packages.nix. Usually this would also involve adding an alias for the old name, but since it's only been in tree for a week I don't think that should be necessary :)

Edit: Oops, missed the previous comments, never mind...

@martinbaillie
Copy link
Contributor Author

martinbaillie commented May 15, 2020

Hey, just a ping on this one. I wanted to defer judgement to the more experienced maintainers that may be reading. I kept the attribute name the same to match the naming used in nixpkgs currently for the parent tool, but have updated the pname to match the wider packaging ecosystem (AUR in this case).

Parent tool:
attribute: ssm-agent
pname: amazon-ssm-agent

This PR as it stands:
attribute: ssm-session-manager-plugin
pname: aws-session-manager-plugin

@martinbaillie martinbaillie force-pushed the martinbaillie:master branch from 80a5574 to 993af93 Jun 4, 2020
@martinbaillie martinbaillie force-pushed the martinbaillie:master branch from 993af93 to 3437d3c Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.