Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the-way: init at 0.3.2 #87710

Merged
merged 4 commits into from Jun 19, 2020
Merged

the-way: init at 0.3.2 #87710

merged 4 commits into from Jun 19, 2020

Conversation

@numkem
Copy link
Contributor

numkem commented May 13, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@Gaelan
Copy link
Contributor

Gaelan commented May 15, 2020

Don't forget to add this to all-packages.nix :)

@numkem numkem force-pushed the numkem:the-way branch 2 times, most recently from fa1d94e to f3e5491 May 15, 2020
@numkem numkem requested a review from jonringer May 15, 2020
@numkem numkem changed the title the-way: init at 0.2.3 the-way: init at 0.3.2 Jun 7, 2020
@numkem numkem force-pushed the numkem:the-way branch from f3e5491 to 8422111 Jun 7, 2020
@numkem
Copy link
Contributor Author

numkem commented Jun 7, 2020

@jonringer I've fixed the tests so they are running correctly and updated the package to use version 0.3.2 instead of 0.2.3.

numkem and others added 2 commits Jun 18, 2020
Co-authored-by: Lassulus <github@lassul.us>
Co-authored-by: Lassulus <github@lassul.us>
@numkem numkem requested a review from Lassulus Jun 18, 2020
@Lassulus Lassulus merged commit 5a345d6 into NixOS:master Jun 19, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="08d391f"; rev="08d391fc41a50230744e1498839b4226b44b9255"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="08d391f"; rev="08d391fc41a50230744e1498839b4226b44b9255"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="08d391f"; rev="08d391fc41a50230744e1498839b4226b44b9255"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="08d391f"; rev="08d391fc41a50230744e1498839b4226b44b9255"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="08d391f"; rev="08d391fc41a50230744e1498839b4226b44b9255"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="08d391f"; rev="08d391fc41a50230744e1498839b4226b44b9255"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="08d391f"; rev="08d391fc41a50230744e1498839b4226b44b9255"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
the-way, the-way.passthru.tests on aarch64-linux Success
Details
the-way, the-way.passthru.tests on x86_64-linux Success
Details
@numkem numkem deleted the numkem:the-way branch Jun 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.