Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various window managers #87716

Merged

Conversation

@AndersonTorres
Copy link
Member

AndersonTorres commented May 13, 2020

Motivation for this change

Introduce various small window managers

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
{
###### interface
options = {
services.xserver.windowManager.lwm.enable = mkEnableOption "lwm";

This comment has been minimized.

Copy link
@romildo

romildo May 13, 2020

Contributor

Maybe a more descriptive text for the option is a good idea.

This comment has been minimized.

Copy link
@AndersonTorres

AndersonTorres May 13, 2020

Author Member

How could it be done?

I'm just using a small template I have used in Ouroboros...

This comment has been minimized.

Copy link
@romildo

romildo May 14, 2020

Contributor

You may use a string similar to the description meta attribute of the respective package as the argument for mkEnableOption, instead of using only the window manager name.

This comment has been minimized.

Copy link
@AndersonTorres

AndersonTorres May 15, 2020

Author Member

I will do it in a "treewide" fashion.

yeahwm is a small window manager for X11, inspired by evilwm
berry is a small window manager for X11
lwm is a lightweight window manager
@AndersonTorres AndersonTorres force-pushed the AndersonTorres:weird-window-mangers-upload branch from 704bb3e to 1c2c0b2 May 14, 2020
@AndersonTorres AndersonTorres merged commit 0687add into NixOS:master May 15, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
berry, berry.passthru.tests, lwm, lwm.passthru.tests, smallwm, smallwm.passthru.tests, yeahwm, yeahwm.passthru.tests on aarch64-linux Success
Details
berry, berry.passthru.tests, lwm, lwm.passthru.tests, smallwm, smallwm.passthru.tests, yeahwm, yeahwm.passthru.tests on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="1c2c0b2"; rev="1c2c0b2eb8ead11d06bd840e9a1d6b4d1f86d49e"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="1c2c0b2"; rev="1c2c0b2eb8ead11d06bd840e9a1d6b4d1f86d49e"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="1c2c0b2"; rev="1c2c0b2eb8ead11d06bd840e9a1d6b4d1f86d49e"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="1c2c0b2"; rev="1c2c0b2eb8ead11d06bd840e9a1d6b4d1f86d49e"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="1c2c0b2"; rev="1c2c0b2eb8ead11d06bd840e9a1d6b4d1f86d49e"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="1c2c0b2"; rev="1c2c0b2eb8ead11d06bd840e9a1d6b4d1f86d49e"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="1c2c0b2"; rev="1c2c0b2eb8ead11d06bd840e9a1d6b4d1f86d49e"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@AndersonTorres AndersonTorres deleted the AndersonTorres:weird-window-mangers-upload branch May 15, 2020
dtzWill added a commit to dtzWill/nixpkgs that referenced this pull request May 15, 2020
…rs-upload

Small window managers:

- berry: init at 0.1.5
- smallwm: init at 2020-02-28
- yeahwm: init at 0.3.5
- lwm: init at 1.2.4

(cherry picked from commit 0687add)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.