Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rounded-mgenplus: replace p7zip with libarchive #87727

Closed
wants to merge 1 commit into from

Conversation

@mnacamura
Copy link
Contributor

mnacamura commented May 13, 2020

Motivation for this change

#86417

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@emilazy
Copy link
Member

emilazy commented May 14, 2020

Just a note: this is duplicated slightly in #87837 (sorry, didn't see this PR before submitting!). However, this can land earlier as mine is blocked on fixing derivations that extract .msis.

@mnacamura
Copy link
Contributor Author

mnacamura commented May 15, 2020

@emilazy Good job! Leave it to you!

@mnacamura mnacamura closed this May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.