Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

welle-io: fix, add qtgraphicaleffects to inputs #87732

Merged
merged 1 commit into from May 23, 2020

Conversation

@markuskowa
Copy link
Member

markuskowa commented May 13, 2020

Motivation for this change

Welle-io refuses to start without the qtgraphicaleffects package.
Needs backport to 20.03.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
programm fails to start without this package
Copy link
Contributor

doronbehar left a comment

Builds fine with nixpkgs-review and GUI seems functional.

@markuskowa markuskowa merged commit b85cccb into NixOS:master May 23, 2020
17 checks passed
17 checks passed
welle-io, welle-io.passthru.tests on aarch64-linux No attempt
Details
welle-io, welle-io.passthru.tests on x86_64-darwin No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="68160d7"; rev="68160d7b782360c5e7431d9a71503dae021b44bb"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="68160d7"; rev="68160d7b782360c5e7431d9a71503dae021b44bb"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="68160d7"; rev="68160d7b782360c5e7431d9a71503dae021b44bb"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="68160d7"; rev="68160d7b782360c5e7431d9a71503dae021b44bb"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="68160d7"; rev="68160d7b782360c5e7431d9a71503dae021b44bb"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="68160d7"; rev="68160d7b782360c5e7431d9a71503dae021b44bb"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="68160d7"; rev="68160d7b782360c5e7431d9a71503dae021b44bb"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
welle-io, welle-io.passthru.tests on x86_64-linux Success
Details
@markuskowa markuskowa deleted the markuskowa:fix-welle-io branch May 23, 2020
@markuskowa
Copy link
Member Author

markuskowa commented May 23, 2020

Backported to 20.03 in b13ffa2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.