Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

syncthingtray: test --help in installCheckPhase #87734

Merged
merged 1 commit into from May 22, 2020

Conversation

@doronbehar
Copy link
Contributor

doronbehar commented May 13, 2020

Motivation for this change

To spare my self the need to test this package every time @r-ryantm updates it for me, I want to be sure it passes this sanity test.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Contributor

bjornfor left a comment

Nit: the commit message is missing the motivation (the why part) for the change. (The PR has it though.)

To spare the need to test this package every time @r-ryantm updates it,
make sure it passes this sanity test.
@doronbehar doronbehar force-pushed the doronbehar:improve-syncthingtray branch from 2f12cf5 to 8bdbd59 May 21, 2020
@doronbehar
Copy link
Contributor Author

doronbehar commented May 22, 2020

@bjornfor I've force pushed a new commit message and all ci checks have passed just as before.

@bjornfor bjornfor merged commit d8fc7de into NixOS:master May 22, 2020
18 checks passed
18 checks passed
editorconfig editorconfig
Details
syncthingtray, syncthingtray.passthru.tests on x86_64-darwin No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8bdbd59"; rev="8bdbd5954183dad5cda1a7305375dcee98e5e0c2"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8bdbd59"; rev="8bdbd5954183dad5cda1a7305375dcee98e5e0c2"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8bdbd59"; rev="8bdbd5954183dad5cda1a7305375dcee98e5e0c2"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8bdbd59"; rev="8bdbd5954183dad5cda1a7305375dcee98e5e0c2"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8bdbd59"; rev="8bdbd5954183dad5cda1a7305375dcee98e5e0c2"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8bdbd59"; rev="8bdbd5954183dad5cda1a7305375dcee98e5e0c2"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="8bdbd59"; rev="8bdbd5954183dad5cda1a7305375dcee98e5e0c2"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
syncthingtray, syncthingtray.passthru.tests on aarch64-linux Success
Details
syncthingtray, syncthingtray.passthru.tests on x86_64-linux Success
Details
@bjornfor
Copy link
Contributor

bjornfor commented May 22, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.