Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport: visidata is supported on darwin + add setuptools #87743

Merged
merged 2 commits into from May 13, 2020

Conversation

@badmutex
Copy link
Contributor

badmutex commented May 13, 2020

Motivation for this change

Use visidata on darwin. This brings the 20.03 branch up to date with master.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
teto and others added 2 commits Mar 23, 2020
and ran nixpkgs-fmt.

This allows to access visidata's help via ctrl+H.

(cherry picked from commit d21cf30)
(cherry picked from commit b332947)
@ofborg ofborg bot requested a review from 7c6f434c May 13, 2020
@7c6f434c 7c6f434c merged commit bd561f6 into NixOS:release-20.03 May 13, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="05d17d0"; rev="05d17d06c906a50c1e31fe9c8eed91c19216e537"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="05d17d0"; rev="05d17d06c906a50c1e31fe9c8eed91c19216e537"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="05d17d0"; rev="05d17d06c906a50c1e31fe9c8eed91c19216e537"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="05d17d0"; rev="05d17d06c906a50c1e31fe9c8eed91c19216e537"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="05d17d0"; rev="05d17d06c906a50c1e31fe9c8eed91c19216e537"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="05d17d0"; rev="05d17d06c906a50c1e31fe9c8eed91c19216e537"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="05d17d0"; rev="05d17d06c906a50c1e31fe9c8eed91c19216e537"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
visidata, visidata.passthru.tests on aarch64-linux Success
Details
visidata, visidata.passthru.tests on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.