Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ubertooth package and module #87750

Open
wants to merge 3 commits into
base: master
from
Open

Ubertooth package and module #87750

wants to merge 3 commits into from

Conversation

@geistesk
Copy link
Member

geistesk commented May 13, 2020

Motivation for this change

Add the host driver for an Ubertooth as a package and a module. Therefore, the required libbtbb is added first.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@Mic92
Copy link
Contributor

Mic92 commented May 26, 2020

@GrahamcOfBorg build ubertooth

@Mic92
Copy link
Contributor

Mic92 commented May 26, 2020

Result of nixpkgs-review pr 87750 1

1 package blacklisted:
- tests.nixos-functions.nixos-test
2 packages built:
- libbtbb
- ubertooth
sourceRoot = "source/host";

nativeBuildInputs = [ cmake pkgconfig ];
buildInputs = [ bluez libbtbb libpcap libusb1 ];

This comment has been minimized.

Copy link
@Mic92

Mic92 May 26, 2020

Contributor

I suppose to make it build, we also remove bluez on macOS.
Could be done by someone who actually has macOS though.

This comment has been minimized.

Copy link
@geistesk

geistesk May 26, 2020

Author Member

Thanks for this catch. Based on the Build Guide their are no additional dependencies for macOS. Thus, I would make this optional and perhaps somebody could check this? Otherwise I would mark this as a Linux-only package.

This comment has been minimized.

Copy link
@Mic92

This comment has been minimized.

Copy link
@geistesk

geistesk May 26, 2020

Author Member

The updated PR should now contain CoreBluetooth and IOBluetooth for Darwin. However, I have no idea if this does the trick.

This comment has been minimized.

Copy link
@geistesk

geistesk Jun 2, 2020

Author Member

@Mic92: What do you think about this changes? What do you think needs to be done to merge the PR?

@geistesk geistesk force-pushed the geistesk:ubertooth branch from 5e31225 to 127c940 May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.