Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vim-beancount: fix broken #87756

Merged
merged 1 commit into from Jun 23, 2020
Merged

Conversation

@siriobalmelli
Copy link
Contributor

siriobalmelli commented May 13, 2020

Signed-off-by: Sirio Balmelli sirio@b-ad.ch

Motivation for this change

vim-beancount package would fail to invoke autocompletion at runtime with: ModuleNotFoundError: No module named 'beancount'

Things done

Add python3 dependency to vim-beancount override.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@siriobalmelli siriobalmelli requested a review from jonringer as a code owner May 13, 2020
@siriobalmelli siriobalmelli force-pushed the siriobalmelli-foss:fix/vim-beancount branch 2 times, most recently from 143b273 to 4072839 May 23, 2020
@siriobalmelli siriobalmelli force-pushed the siriobalmelli-foss:fix/vim-beancount branch 2 times, most recently from fe310c8 to 9b4f9a9 Jun 1, 2020
@siriobalmelli siriobalmelli force-pushed the siriobalmelli-foss:fix/vim-beancount branch 2 times, most recently from 5083dcf to a331b41 Jun 10, 2020
@siriobalmelli siriobalmelli force-pushed the siriobalmelli-foss:fix/vim-beancount branch 2 times, most recently from 54d644f to 305d3b3 Jun 18, 2020
@siriobalmelli siriobalmelli changed the title vim-beancount: dependency on python3 'beancount' package vim-beancount: fix broken Jun 20, 2020
Runtime dependency on python3 'beancount' package needed
for autocompletion engine.

Signed-off-by: Sirio Balmelli <sirio@b-ad.ch>
@siriobalmelli siriobalmelli force-pushed the siriobalmelli-foss:fix/vim-beancount branch from 305d3b3 to ffb2108 Jun 20, 2020
@siriobalmelli
Copy link
Contributor Author

siriobalmelli commented Jun 23, 2020

This pull request has been open since 13 May.

Would be great to be able to get it merged and stop tracking and periodically rebasing a separate branch in my repo.

I've gone through CONTIBUTING.md a couple times and if there's something I should be doing to improve this pull request I don't see it.

Any feedback is much appreciated.

... I can assure you the fix is stable, I daily-drive Vim with this plugin enabled.

@jonringer
Copy link
Contributor

jonringer commented Jun 23, 2020

diff LGTM, sorry i didn't get around to it sooner

Copy link
Contributor

jonringer left a comment

LGTM

Result of nixpkgs-review pr 87756 1

@jonringer jonringer merged commit d5b6a9c into NixOS:master Jun 23, 2020
13 checks passed
13 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ffb2108"; rev="ffb210870bbb2e98f1ef95f79a95068533cd22a9"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ffb2108"; rev="ffb210870bbb2e98f1ef95f79a95068533cd22a9"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ffb2108"; rev="ffb210870bbb2e98f1ef95f79a95068533cd22a9"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ffb2108"; rev="ffb210870bbb2e98f1ef95f79a95068533cd22a9"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ffb2108"; rev="ffb210870bbb2e98f1ef95f79a95068533cd22a9"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ffb2108"; rev="ffb210870bbb2e98f1ef95f79a95068533cd22a9"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ffb2108"; rev="ffb210870bbb2e98f1ef95f79a95068533cd22a9"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@siriobalmelli
Copy link
Contributor Author

siriobalmelli commented Jun 24, 2020

diff LGTM, sorry i didn't get around to it sooner

No worries - and I notice you handle a lot of the package review for Nix!
That's certainly much appreciated.

@siriobalmelli siriobalmelli deleted the siriobalmelli-foss:fix/vim-beancount branch Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.